Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavigationBarItem Update #2526

Closed
wants to merge 7 commits into from
Closed

NavigationBarItem Update #2526

wants to merge 7 commits into from
+164 −27

Conversation

Iragne
Copy link
Contributor

@Iragne Iragne commented Sep 2, 2015

Provide a function to update NavigationbarItem (button, title...)
Provide TitleIcon property
Fix Recursive render of hidden viewController
Provide Exemple

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 2, 2015
@Iragne Iragne mentioned this pull request Sep 3, 2015
Closed
jean-alexandre iragne added 6 commits September 4, 2015 14:21
@Iragne Iragne mentioned this pull request Sep 7, 2015
Closed
@cancan101
Copy link
Contributor

What's up with the PR?

@facebook-github-bot
Copy link
Contributor

@Iragne updated the pull request.

@Iragne
Copy link
Contributor Author

Iragne commented Nov 16, 2015

@cancan101 i will restart to create it in the next days

@ghost
Copy link

ghost commented Mar 7, 2016

@mrspeaker would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

@mkonicek
Copy link
Contributor

@Iragne Note that the Navigator is getting deprecated in favor of NavigationExperimental. Do you still plan to work on this or should we close it? I'm going through all PRs now making sure each PRs is either being actively worked on or closed, to keep the number of open PRs under control.

@jsierles
Copy link
Contributor

@facebook-github-bot no-reply

@Iragne
Copy link
Contributor Author

Iragne commented Apr 27, 2016

Well i woudl like to have time to work on it and don't let the comunity like that but i'm running out of time.
May be in the next month i will be able to update it

@facebook-github-bot
Copy link
Contributor

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @ericvicenti as a potential reviewer. Could you take a look please or cc someone with more context?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2016
@javache
Copy link
Member

javache commented Aug 4, 2016

This pull request hasn't seen activity in a while. If you still want to merge this, please open a new pull request.

@javache javache closed this Aug 4, 2016
@csujedihy
Copy link

This functionality is pretty useful.

@skycocker
Copy link

@Iragne thanks for this one, did help me a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Iragne @cancan101 @facebook-github-bot @mkonicek @jsierles @javache @csujedihy @skycocker