-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open links from new app screen in computer's browser #24843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super good! I'll import this and land it. Thank you so so so much :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
This pull request was successfully merged by @lucasbento in aa926e3. When will my fix make it into a release? | Upcoming Releases |
It looks like
|
Here's how I verified the regression was introduced in the commit associated with this PR:
|
We have a fix for that coming: react-native-community/cli#376 will prioritize it today |
Summary: PR #24843 broke Android tests because of a regression we introduced in terms of passing `reporter` argument to Metro config. This was fixed in latest `alpha.20` release of CLI ## Changelog [General] [Fix] - update CLI to alpha.20 to fix Android tests Pull Request resolved: #24869 Reviewed By: rickhanlonii Differential Revision: D15355144 Pulled By: cpojer fbshipit-source-id: faafd8098c708845264b7164557076bce45ea332
Summary: PR facebook#24843 broke Android tests because of a regression we introduced in terms of passing `reporter` argument to Metro config. This was fixed in latest `alpha.20` release of CLI ## Changelog [General] [Fix] - update CLI to alpha.20 to fix Android tests Pull Request resolved: facebook#24869 Reviewed By: rickhanlonii Differential Revision: D15355144 Pulled By: cpojer fbshipit-source-id: faafd8098c708845264b7164557076bce45ea332
Summary
This PR is related to #24760 and adds the
openURLInBrowser
functionality introduced on react-native-community/cli#383.Changelog
[General] [Changed] - Open links from new app in computer's browser.
Test Plan
npm i
to install the new dep (bumped@react-native-community/cli
tov2.0.0-alpha.19
);RNTester/RNTesterPods.xcworkspace
;new
in the list of theRNTester
, tap the first item and click on any link, that link should open in your computer's default browser.If any of these steps don't work please let me know and we will fix them.
cc @cpojer.