Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][Bug] - fix crash on performance logger #24821

Closed
wants to merge 7 commits into from

Conversation

zhigang1992
Copy link
Contributor

@zhigang1992 zhigang1992 commented May 12, 2019

Summary

Fix Issue #24820

It's caused by _labelsForTags and RCTPLTag being out of sync, the crash might only be one of the issues that this bug was causing.

Changelog

[iOS] [Fixed] - fix crash on performance logger

Test Plan

  • Launch iOS simulator
  • Enable performance monitor
  • Tap on performance monitor

It should not crash

@zhigang1992 zhigang1992 requested a review from shergin as a code owner May 12, 2019 08:26
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@react-native-bot react-native-bot added Platform: iOS iOS applications. Bug labels May 12, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@@ -7,6 +7,7 @@

#import <Foundation/Foundation.h>

// Keep this in sync with _labelsForTags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd better to remove these missing labels in _labelForTags? because we don't use these enums at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, +1

@cpojer
Copy link
Contributor

cpojer commented May 17, 2019

@zhigang1992 could you make the change that was suggested by @zhongwuzw?

…rfMonitorCrash

# Conflicts:
#	React/Base/RCTPerformanceLogger.h
#	React/Base/RCTPerformanceLogger.m
@zhigang1992
Copy link
Contributor Author

All the unused flags are now removed except RCTPLJSCWrapperOpenLibrary. Which was added in abe0b34 Should I remove that as well?

Copy link
Contributor

@zhongwuzw zhongwuzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhongwuzw
Copy link
Contributor

All the unused flags are now removed except RCTPLJSCWrapperOpenLibrary. Which was added in abe0b34 Should I remove that as well?

We can keep it, don't break RCTPLTag enum.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeteTheHeat is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @zhigang1992 in 5d3d398.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 18, 2019
@zhigang1992 zhigang1992 deleted the fix/perfMonitorCrash branch May 26, 2019 09:51
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
Summary:
Fix Issue facebook#24820

It's caused by `_labelsForTags` and `RCTPLTag` being out of sync, the crash might only be one of the issues that this bug was causing.

## Changelog

[iOS] [Fixed] - fix crash on performance logger
Pull Request resolved: facebook#24821

Differential Revision: D15407291

Pulled By: PeteTheHeat

fbshipit-source-id: c8d2a047fceb9cec981c48fe5181d1b4cbf0976c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants