Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event ordering when combining coalescable and non-coalescable events #24693

Closed

Conversation

janicduplessis
Copy link
Contributor

Summary

Fixes an issue introduced in #15894 that can cause events to be dispatched out of order.

Also reverted viewTag moved to optional property as it didn't actually work and makes code more complex.

Changelog

[iOS] [Fixed] - Fix event ordering when combining coalescable and non-coalescable events

Test Plan

Tested events still work, need to validate it fixes the crash seen @fb

@janicduplessis janicduplessis requested a review from shergin as a code owner May 2, 2019 17:52
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels May 2, 2019
@janicduplessis
Copy link
Contributor Author

@shergin @sahrens Can you test if this fixes the issue you reported?

@shergin
Copy link
Contributor

shergin commented May 9, 2019

AFAIK, this is hard to repro issue which happens only in prod at scale (one of our top crashes thought!).

Looks good and reasonable to me! Thank you so much Janic! ❤️

So, let's land and see what happened. 🤞

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @janicduplessis in 4e215b2.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 9, 2019
@janicduplessis janicduplessis deleted the fix-event-ordering branch May 9, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants