-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[template] add jsc pickFirst packagingOptions #24535
Conversation
@Salakar I am sorry to introduce this issue. |
Hey @Kudo - this was just a fresh RN init of the template currently on 0.60-stable branch (no extra changes made) - there was also nothing extra after the screenshot sorry. I guess the only difference is that it points to the 0.59.5 RN release Reproducible example from the template is here: https://github.com/invertase/react-native-auto-link-example (a single |
@Salakar Yes, the problem may related to 0.59.5 release. |
@Kudo I agree that this is most likely down to 0.59.5 as well. Maybe it's still worth merging this though, in case anyone downgrades their template for whatever reason (it happens)? |
@Salakar IMHO, pickFirst is not reliable to choose correct JSC. In fact, we are trying to remove the pickFirst for libc++_shared.so as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna land this because it prevents a painful issue for some people in certain situations but I agree we should get rid of the pickFirst
stuff altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@Kudo that's fair, how would you recommend we remove pickFirst behaviour as I can do another PR for this |
This pull request was successfully merged by @Salakar in 7ac1d18. When will my fix make it into a release? | Upcoming Releases |
@Salakar I still waiting for the PR which exclude libc++_shared.so being merged and release a new version to npm. |
Summary
Fixes the following build failures on Android Studio (happening when using the 0.60 template):
cc @dulmandakh
Changelog
[Android] [Fixed] - Fixed a
more than one file was found... lib/x86/libjsc.so
build failure with the templateTest Plan
Build is now successful and the app starts with this change: