Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compiler warning #23588

Closed
wants to merge 2 commits into from
Closed

Conversation

zhongwuzw
Copy link
Contributor

@zhongwuzw zhongwuzw commented Feb 22, 2019

Summary

Fixed compiler warning, after this, seems we have no warning for framework in debug mode.
image

Changelog

[iOS] [Fixed] - Remove compiler warning

Test Plan

Build and run as before, not see warnings.

@zhongwuzw zhongwuzw requested a review from shergin as a code owner February 22, 2019 06:45
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 22, 2019
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Finally we got rid of all the warnings, yayyy!

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 22, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

react-native-bot commented Feb 22, 2019

@zhongwuzw merged commit 81860c5 into facebook:master.

When will my fix make it into a release? | Upcoming Releases

@facebook facebook locked as resolved and limited conversation to collaborators Feb 22, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 22, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants