Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit conversion warning in RCTInspector.mm #23577

Closed
wants to merge 1 commit into from

Conversation

fson
Copy link
Contributor

@fson fson commented Feb 21, 2019

Summary

Fixes Xcode warning: Implicit conversion loses integer precision: 'NSInteger' (aka 'long') to 'int'.

Changelog

[iOS] [Fixed] - Fix implicit conversion warning in RCTInspector.mm

Test Plan

Checked that RNTester was built without this warning in Xcode.

Fixes Xcode warning: Implicit conversion loses integer precision:
'NSInteger' (aka 'long') to 'int'
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2019
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 21, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@fson merged commit 0cffdaa into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Feb 21, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 21, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 23, 2019
@fson fson deleted the @fson/fix-implicit-conversion branch March 19, 2019 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants