Fix xcode warnings #23565
Closed
Fix xcode warnings #23565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This brings the React target down to 13 warnings. Removing RCTWKWebView as noted in #23313 will bring it down to 9! |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@ericlewis merged commit 468ae23 into |
mbardauskas
pushed a commit
to mbardauskas/react-native
that referenced
this pull request
Feb 21, 2019
Summary: As part of facebook#22609, this fixes yet more warnings. - Adding more __unused to params. - Refactors `isPackagerRunning` to use NSURLSession. - Turns off suspicious comma warnings [iOS] [Fixed] - Xcode Warnings Pull Request resolved: facebook#23565 Differential Revision: D14161151 Pulled By: cpojer fbshipit-source-id: 339874711eca718fc6151e84737ccc975225d736
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of #22609, this fixes yet more warnings.
isPackagerRunningto use NSURLSession.Changelog
[iOS] [Fixed] - Xcode Warnings
Test Plan
Observe less warnings when running.