[iOS] Add folly_compiler_flags to Core subspec
#23488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Salakar
changed the title
folly_compiler_flags to Core subspecfolly_compiler_flags to Core subspec
|
( |
matthargett
approved these changes
Feb 16, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 17, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
grabbou
pushed a commit
that referenced
this pull request
Feb 18, 2019
Summary: This fixes the following iOS build error when using React via pods (using the new Xcode build system); > project/Pods/Folly/folly/portability/Config.h:20:10: 'folly/folly-config.h' file not found react-native-community/releases#79 (comment) react-native-community/releases#79 (comment) react-native-community/releases#79 (comment) [iOS] [Fixed] - Fixed a "'folly/folly-config.h' file not found" build error when using React via CocoaPods Pull Request resolved: #23488 Differential Revision: D14121296 Pulled By: cpojer fbshipit-source-id: 5eb2ba3066aef2bc9cfb95a9172cbef921c47170
ericlewis
pushed a commit
to ericlewis/react-native
that referenced
this pull request
Feb 20, 2019
Summary: This fixes the following iOS build error when using React via pods (using the new Xcode build system); > project/Pods/Folly/folly/portability/Config.h:20:10: 'folly/folly-config.h' file not found react-native-community/releases#79 (comment) react-native-community/releases#79 (comment) react-native-community/releases#79 (comment) [iOS] [Fixed] - Fixed a "'folly/folly-config.h' file not found" build error when using React via CocoaPods Pull Request resolved: facebook#23488 Differential Revision: D14121296 Pulled By: cpojer fbshipit-source-id: 5eb2ba3066aef2bc9cfb95a9172cbef921c47170
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the following iOS build error when using React via pods (using the new Xcode build system);
react-native-community/releases#79 (comment)
react-native-community/releases#79 (comment)
react-native-community/releases#79 (comment)
Changelog
[iOS] [Fixed] - Fixed a "'folly/folly-config.h' file not found" build error when using React via CocoaPods
Test Plan
Before:
After:
