bump android plugin to 3.3.1 #23473
Closed
bump android plugin to 3.3.1 #23473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
gengjiawen
approved these changes
Feb 15, 2019
gengjiawen
reviewed
Feb 15, 2019
| @@ -13,7 +13,7 @@ buildscript { | |||
| jcenter() | |||
| } | |||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:3.3.0' | |||
| classpath 'com.android.tools.build:gradle:3.3.1' | |||
react-native-bot
added
Platform: Android
cpojer
approved these changes
Feb 15, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 15, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dulmandakh merged commit da5b5d2 into |
grabbou
pushed a commit
that referenced
this pull request
Feb 15, 2019
Summary: Bump Android Plugin to 3.3.1, with many bug fixes and performance improvements. Split the change from #23324 to make cherry-pick easy to 0.59 branch. [Android] [Changed] - bump Android Plugin to 3.3.1 Pull Request resolved: #23473 Differential Revision: D14099741 Pulled By: cpojer fbshipit-source-id: 7491c49cd2467f1bb8776345bdda2ab9cea11c06
radeno
referenced
this pull request
Feb 21, 2019
Summary: This PR bumps gradle to 5.0, which includes Kotlin DSL 1.0, and android gradle plugin to 3.3.1, which includes includes various bug fixes and performance improvements. Also Gradle 5.x requires Java 8. This is preparation for Kotlin DSL migration. [Android] [Changed] - Bump Gradle to 5.0 Pull Request resolved: #23324 Reviewed By: mdvacca Differential Revision: D14028563 Pulled By: hramos fbshipit-source-id: 61fe1a2d4ea5707d6f07945acbd950f852420e13
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump Android Plugin to 3.3.1, with many bug fixes and performance improvements. Split the change from #23324 to make cherry-pick easy to 0.59 branch.
Changelog
[Android] [Changed] - bump Android Plugin to 3.3.1
Test Plan
CI is green