[iOS] Add ImageIO related C nullable check to prevent crash #23186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
facebook-github-bot
approved these changes
Jan 28, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
react-native-bot
added
Component: Image
Platform: iOS
|
@zhongwuzw merged commit d0cd3ca into |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Changelog: ---------- [iOS] [Fixed] - Add ImageIO related C nullable check to prevent crash Pull Request resolved: facebook#23186 Differential Revision: D13838590 Pulled By: cpojer fbshipit-source-id: 14bfa826ce75c32129e6a980a04bb85fb35411a0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
[iOS] [Fixed] - Add ImageIO related C nullable check to prevent crash
Test Plan:
Before
PR, ifCGImageSourceCreateWithDataorCGImageSourceCreateImageAtIndexreturnNULL, some likedatais not a valid, or any image data at any index is invalid, or system error, can leads to crash. AfterPR, we can omit theNULLthings.