Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android support library 28.0.0 #23109

Closed
wants to merge 5 commits into from

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Jan 23, 2019

Bump Android Support Library to 28.0.0. Therefore fix Android CI

Changelog:

[Android] [Changed] - Bump Android Support Library to 28.0.0.

Test Plan:

CI is green

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2019
@dulmandakh
Copy link
Contributor Author

@mdvacca Android CI is green

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@gengjiawen gengjiawen mentioned this pull request Jan 23, 2019
Copy link
Contributor

@mdvacca mdvacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR and fixing CI!!!

I added some comments to make this PR to work with the FB infra.

@@ -1,54 +1,131 @@
load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add "rn_prebuilt_jar" here?

load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "rn_prebuilt_jar")

":swiperefreshlayout",
":versionedparcelable",
":viewpager",
react_native_dep("third-party/android/support-annotations:android-support-annotations"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's replace this for:

":android-support-annotations",

":swiperefreshlayout",
":versionedparcelable",
":viewpager",
react_native_dep("third-party/android/support-annotations:android-support-annotations"),
],
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add?

fb_native.prebuilt_jar(
name = "android-support-annotations",
binary_jar = ":support-annotations-binary.jar",
)

url = "mvn:android.arch.lifecycle:runtime:aar:1.1.0",
name = "asynclayoutinflater-aar",
sha1 = "3ae7643d120e6da3adbe2d698de923f48c904d1f",
url = "mvn:com.android.support:asynclayoutinflater:aar:28.0.0",
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add?

fb_native.remote_file(
name = "support-annotations-binary.jar",
sha1 = "ed73f5337a002d1fd24339d5fb08c2c9d9ca60d8",
url = "mvn:com.android.support:support-annotations:jar:28.0.0",
)

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 23, 2019
@react-native-bot
Copy link
Collaborator

@dulmandakh merged commit 5bbed43 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 23, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 23, 2019
grabbou pushed a commit that referenced this pull request Jan 23, 2019
Summary:
Bump Android Support Library to 28.0.0. Therefore fix Android CI

Changelog:
----------
[Android] [Changed] - Bump Android Support Library to 28.0.0.
Pull Request resolved: #23109

Differential Revision: D13779835

Pulled By: mdvacca

fbshipit-source-id: 7645ffe2c04ca81424b2f9cfa43dc4ec30c50e25
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
Summary:
Bump Android Support Library to 28.0.0. Therefore fix Android CI

Changelog:
----------
[Android] [Changed] - Bump Android Support Library to 28.0.0.
Pull Request resolved: facebook#23109

Differential Revision: D13779835

Pulled By: mdvacca

fbshipit-source-id: 7645ffe2c04ca81424b2f9cfa43dc4ec30c50e25
@dulmandakh dulmandakh deleted the support-28.0.0 branch February 22, 2019 14:23
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
Summary:
Bump Android Support Library to 28.0.0. Therefore fix Android CI

Changelog:
----------
[Android] [Changed] - Bump Android Support Library to 28.0.0.
Pull Request resolved: facebook#23109

Differential Revision: D13779835

Pulled By: mdvacca

fbshipit-source-id: 7645ffe2c04ca81424b2f9cfa43dc4ec30c50e25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants