[Standalone for Native Component] ActivityIndicator #23104
Conversation
All the imports connected to requireNativeComponent in ActivityIndicator was moved to a seperate file.
facebook-github-bot
added
the
CLA Signed
Libraries/Components/ActivityIndicator/ActivityIndicatorNativeComponent.js
Outdated
Show resolved
Hide resolved
Libraries/Components/ActivityIndicator/ActivityIndicatorNativeComponent.js
Outdated
Show resolved
Hide resolved
|
@TheSavior, were the tests failing already or did this PR trigger them? |
|
|
||
| type NativeProps = $ReadOnly<{| | ||
| ...ViewProps, | ||
|
|
|
|
||
| type NativeProps = $ReadOnly<{| | ||
| ...ViewProps, | ||
|
|
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
| * See http://facebook.github.io/react-native/docs/activityindicator.html#size | ||
| */ | ||
| size?: ?(number | 'small' | 'large'), | ||
|
|
There was a problem hiding this comment.
prettier/prettier: Delete ························
| * See http://facebook.github.io/react-native/docs/activityindicator.html#size | ||
| */ | ||
| size?: ?(number | 'small' | 'large'), | ||
|
|
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
|
|
||
| type NativeProps = $ReadOnly<{| | ||
| ...ViewProps, | ||
|
|
|
|
||
| type NativeProps = $ReadOnly<{| | ||
| ...ViewProps, | ||
|
|
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
| * See http://facebook.github.io/react-native/docs/activityindicator.html#size | ||
| */ | ||
| size?: ?(number | 'small' | 'large'), | ||
|
|
There was a problem hiding this comment.
prettier/prettier: Delete ························
| * See http://facebook.github.io/react-native/docs/activityindicator.html#size | ||
| */ | ||
| size?: ?(number | 'small' | 'large'), | ||
|
|
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I'll ship this. Thanks for making this PR! :) |
facebook-github-bot
added
the
Import Started
|
@VisibleMarkov merged commit 5503355 into |
hramos
removed
Import Started
Summary: PR Related to: facebook#22990 Changelog: [Android][Changed] - All the imports connected to requireNativeComponent in ActivityIndicator was moved to a seperate file. Pull Request resolved: facebook#23104 Differential Revision: D13781451 Pulled By: cpojer fbshipit-source-id: 7204976d59a96abdaa81cdd7fd54fd001f7d1ee9
PR Related to: #22990
Changelog:
[Android][Changed] - All the imports connected to requireNativeComponent in ActivityIndicator was moved to a seperate file.
Test Plan: