Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PushNotificationIOS] fixes requestPermissions base on @DannyvanderJagt… #2302

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2015

fixes PushNotificationIOS requestPermissions base on @DannyvanderJagt's fix in #1979

@ghost ghost changed the title fixes PushNotificationIOS requestPermissions base on @DannyvanderJagt… [PushNotificationIOS] fixes requestPermissions base on @DannyvanderJagt… Aug 11, 2015
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@DannyvanderJagt
Copy link
Contributor

@potsypantsy Did you already sign the cla?

@ghost
Copy link
Author

ghost commented Aug 13, 2015

@DannyvanderJagt I will sign the cla. But the the bigger problem is actually the tests failing. I am unable to get the tests to pass :(

@DannyvanderJagt
Copy link
Contributor

Does the master pass all of its tests? I will take a look at it in a few hours, maybe I can help you.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2015
@DannyvanderJagt
Copy link
Contributor

I have created a branch with the same changes as this PR and all the tests are passing. Maybe a rebase will help.

Besides the rebase the only thing that is different is that I removed this from .travis.yml:

branches:
  only:
    - master

But that shouldn't be a problem.

@ghost
Copy link
Author

ghost commented Aug 14, 2015

@DannyvanderJagt I rebased hopefully tests will pass

@ghost
Copy link
Author

ghost commented Aug 14, 2015

@DannyvanderJagt tests still fail :( maybe you should make the pr instead. I will just close this one.

@ghost ghost closed this Aug 14, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants