-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PushNotificationIOS] fixes requestPermissions base on @DannyvanderJagt… #2302
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
@potsypantsy Did you already sign the cla? |
@DannyvanderJagt I will sign the cla. But the the bigger problem is actually the tests failing. I am unable to get the tests to pass :( |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I have created a branch with the same changes as this PR and all the tests are passing. Maybe a rebase will help. Besides the rebase the only thing that is different is that I removed this from
But that shouldn't be a problem. |
@DannyvanderJagt I rebased hopefully tests will pass |
@DannyvanderJagt tests still fail :( maybe you should make the pr instead. I will just close this one. |
fixes PushNotificationIOS requestPermissions base on @DannyvanderJagt's fix in #1979