fix incorrect type which makes animated gifs not loop forever on device #22987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
3 tasks
Generated by 🚫 dangerJS |
|
Would appreciate if it would be possible to merge this change, thank you!! |
hramos
added
Missing Changelog
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@chrisnojima merged commit 728a35f into |
ButtersHub
pushed a commit
to wix-playground/react-native
that referenced
this pull request
Jan 30, 2019
…ce (facebook#22987) Summary: facebook#22985 This 1 liner fixes the animation looping being broken on ios devices. The original source of the bug is here: facebook@95ef882#diff-e57b12f931820d7e0949e5cbb2701dcfR35 We set the value to a special large float, and assign it to repeatCount which is also a float, so this should be a float. Changelog: [iOS] [Fixed] - Fix animated GIFs not looping forever Pull Request resolved: facebook#22987 Differential Revision: D13682645 Pulled By: hramos fbshipit-source-id: 96b0602b418e3ebe369427a24777cd4374ac5d48
grabbou
pushed a commit
that referenced
this pull request
Feb 6, 2019
…ce (#22987) Summary: #22985 This 1 liner fixes the animation looping being broken on ios devices. The original source of the bug is here: 95ef882#diff-e57b12f931820d7e0949e5cbb2701dcfR35 We set the value to a special large float, and assign it to repeatCount which is also a float, so this should be a float. Changelog: [iOS] [Fixed] - Fix animated GIFs not looping forever Pull Request resolved: #22987 Differential Revision: D13682645 Pulled By: hramos fbshipit-source-id: 96b0602b418e3ebe369427a24777cd4374ac5d48
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
…ce (facebook#22987) Summary: facebook#22985 This 1 liner fixes the animation looping being broken on ios devices. The original source of the bug is here: facebook@95ef882#diff-e57b12f931820d7e0949e5cbb2701dcfR35 We set the value to a special large float, and assign it to repeatCount which is also a float, so this should be a float. Changelog: [iOS] [Fixed] - Fix animated GIFs not looping forever Pull Request resolved: facebook#22987 Differential Revision: D13682645 Pulled By: hramos fbshipit-source-id: 96b0602b418e3ebe369427a24777cd4374ac5d48
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…ce (facebook#22987) Summary: facebook#22985 This 1 liner fixes the animation looping being broken on ios devices. The original source of the bug is here: facebook@95ef882#diff-e57b12f931820d7e0949e5cbb2701dcfR35 We set the value to a special large float, and assign it to repeatCount which is also a float, so this should be a float. Changelog: [iOS] [Fixed] - Fix animated GIFs not looping forever Pull Request resolved: facebook#22987 Differential Revision: D13682645 Pulled By: hramos fbshipit-source-id: 96b0602b418e3ebe369427a24777cd4374ac5d48
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22985
This 1 liner fixes the animation looping being broken on ios devices. The original source of the bug is here: 95ef882#diff-e57b12f931820d7e0949e5cbb2701dcfR35
We set the value to a special large float, and assign it to repeatCount which is also a float, so this should be a float.
Changelog:
[iOS] [Fixed] - Fix animated GIFs not looping forever