Fix ReactAndroid bundle issue #22799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gengjiawen <technicalcute@gmail.com>
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Tech: Bundler 📦
|
@gengjiawen will this fix react-native-community/releases#41 (comment)? |
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
@dulmandakh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
yes. |
facebook-github-bot
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@gengjiawen merged commit 5dd9d72 into |
grabbou
pushed a commit
that referenced
this pull request
Jan 17, 2019
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Related change: facebook@0a293a0. Changelog: ---------- [Bugfix] [Android] - fix 64bit so bundle issue. Pull Request resolved: facebook#22799 Differential Revision: D13669711 Pulled By: hramos fbshipit-source-id: 0234b4731db0c74c8e4b8b738a19ae971fadb702
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Related change: facebook@0a293a0. Changelog: ---------- [Bugfix] [Android] - fix 64bit so bundle issue. Pull Request resolved: facebook#22799 Differential Revision: D13669711 Pulled By: hramos fbshipit-source-id: 0234b4731db0c74c8e4b8b738a19ae971fadb702
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related change: 0a293a0.
Changelog:
[Bugfix] [Android] - fix 64bit so bundle issue.
Test Plan:
Build and run RNTester in 64bit cpu.