Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flow-strict] Flow ViewPropTypes #22504

Closed
wants to merge 1 commit into from
Closed

[flow-strict] Flow ViewPropTypes #22504

wants to merge 1 commit into from

Conversation

exced
Copy link
Contributor

@exced exced commented Dec 4, 2018

Related to #22100

Enhance ViewPropTypes flow types.

  • I had some troubles with a TODO left for onResponderGrant hence the return type.
  • I wasn't able to properly type nativeBackgroundAndroid and nativeForegroundAndroid at the moment.

Test Plan:

  • All flow tests succeed.

Changelog:

[General][Changed] [ViewPropTypes.js] - Enhance Flow types definitions
[General][Changed] [InspectorOverlay.js] - Enhance Flow types definitions

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2018
@pull-bot
Copy link

pull-bot commented Dec 4, 2018

Warnings
⚠️

📋 Changelog - This PR may have incorrectly formatted Changelog.

Generated by 🚫 dangerJS

facebook-github-bot
facebook-github-bot reviewed Dec 5, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@exced merged commit 9facd81 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Dec 5, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@elicwhite elicwhite Awaiting requested review from elicwhite

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: View Flow Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@exced @pull-bot @react-native-bot @facebook-github-bot