Fix linting issues #22062
Closed
Fix linting issues #22062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
elicwhite
reviewed
Nov 1, 2018
RNTester/e2e/sanity.test.js
Outdated
| @@ -30,7 +30,7 @@ describe('Sanity', () => { | |||
| await element(by.text('OK')).tap(); | |||
| }); | |||
|
|
|||
| it(`Two buttons with JustifyContent:'space-between' should be tappable`, async () => { | |||
| it('Two buttons with JustifyContent:\'space-between\' should be tappable', async () => { | |||
There was a problem hiding this comment.
The linter would be happy with double quotes here and then you don't need to escape the inner ones.
Suggested change
| it('Two buttons with JustifyContent:\'space-between\' should be tappable', async () => { | |
| it("Two buttons with JustifyContent:'space-between' should be tappable", async () => { |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 1, 2018
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for these fixes! |
|
@ignacioola merged commit ae8ec39 into |
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Nov 6, 2018
Summary: Fixes lots of ESLint warnings. Many of them where in PR #20877 by janicduplessis which requested to split the linting fixes from configuration and package changes. I solved only the issues that I was most certain about but I would love to get hands on all of them with a little bit of input. Pull Request resolved: facebook/react-native#22062 Differential Revision: D12889447 Pulled By: TheSavior fbshipit-source-id: 35f7a08104a5b859c860afdde4af2b32c0685c50
hramos
removed
Import Started
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Apr 14, 2019
Summary: Fixes lots of ESLint warnings. Many of them where in PR #20877 by janicduplessis which requested to split the linting fixes from configuration and package changes. I solved only the issues that I was most certain about but I would love to get hands on all of them with a little bit of input. Pull Request resolved: facebook/react-native#22062 Differential Revision: D12889447 Pulled By: TheSavior fbshipit-source-id: 35f7a08104a5b859c860afdde4af2b32c0685c50
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Fixes lots of ESLint warnings. Many of them where in PR facebook#20877 by janicduplessis which requested to split the linting fixes from configuration and package changes. I solved only the issues that I was most certain about but I would love to get hands on all of them with a little bit of input. Pull Request resolved: facebook#22062 Differential Revision: D12889447 Pulled By: TheSavior fbshipit-source-id: 35f7a08104a5b859c860afdde4af2b32c0685c50
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lots of ESLint warnings. Many of them where in PR #20877 by @janicduplessis which requested to split the linting fixes from configuration and package changes.
I solved only the issues that I was most certain about but I would love to get hands on all of them with a little bit of input.
Test Plan:
Run linting from the React Native project:
And see less linting issues than before.
Release Notes:
[INTERNAL] [ENHANCEMENT] [eslint] - Fix eslint issues