Resolve protocol http, https when not in lowercase #21396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Sep 28, 2018
react-native-bot
added
🌐Networking
|
Can someone help me understand why one of the tests have failed? |
RSNara
requested changes
Sep 28, 2018
|
@hyunjongL I don't think your PR broke CI. So, I wouldn't worry about it. |
|
@RSNara check out the changes! |
|
Thanks for the quick fixes! I'll merge this. |
RSNara
approved these changes
Sep 29, 2018
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 29, 2018
There was a problem hiding this comment.
RSNara is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@hyunjongL merged commit d00bdb9 into |
kelset
pushed a commit
that referenced
this pull request
Oct 12, 2018
Summary: Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. _Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_ Pull Request resolved: #21396 Differential Revision: D10119630 Pulled By: RSNara fbshipit-source-id: d0fe193eee976b9b18a2eb467b5f3af48bd7d2de
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. _Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_ Pull Request resolved: facebook#21396 Differential Revision: D10119630 Pulled By: RSNara fbshipit-source-id: d0fe193eee976b9b18a2eb467b5f3af48bd7d2de
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.
If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!
Test Plan:
Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
I have added to my react native app that has to open URLs with protocols(Https) that have uppercases. Added console log of the url back and forth to test if the url has changed.
You can easily build an react-native app like https://snack.expo.io/@hyunjongl/android-linking-protocol-problem and see if this resolves it.
This is the screenshot of the console log where I try to open a URL with Https, and the code will automatically change it into https.
Release Notes:
Fixes #21395
[ANDROID][ENHANCEMENT][Libraries/Linking/Linking.js]
https://snack.expo.io/@hyunjongl/android-linking-protocol-problem
There issue is that when you have a URL with protocol that has an uppercase, it works in iOS, but won't work in Android. (check the Expo above).
There are a lot of user generated URLs in social platforms, and I bet it is not a good Idea to change what the user have wrote. Also currently I feel like iOS and Android behave differently in this issue which makes me feel bad.
So, I am suggesting a way to change the protocol['http://', 'https://'] into lowercase just before opening the browser. However, as I am very new to this community, it might not be the best place to add the lines, so comments are very welcome.
TL;DR Added few lines to change the protocol string to lowercase when some are in uppercase.