Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compileSdkVersion to 27 and buildToolsVersion to 27.0.3 #20777

Closed
wants to merge 1 commit into from

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Aug 22, 2018

I found that android support library 27.x (874cca1) requires compileSdkVersion to be 27. Also found that many FB projects use SDK 27.

Test Plan:

Everything builds and run normally. Warning from support library will disappear.

@dulmandakh dulmandakh requested a review from hramos August 22, 2018 04:03
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 22, 2018
@react-native-bot react-native-bot added ✅Test Plan Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Aug 22, 2018
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Aug 23, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was closed by @dulmandakh in 044b399.

Once this commit is added to a release, you will see the corresponding version tag below the description at 044b399. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Aug 23, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 23, 2018
kelset pushed a commit that referenced this pull request Aug 23, 2018
Summary:
I found that android support library 27.x (874cca1) requires compileSdkVersion to be 27. Also found that many FB projects use SDK 27.
Pull Request resolved: #20777

Differential Revision: D9478431

Pulled By: hramos

fbshipit-source-id: ca100f6b5b39e7d112926124423f9510a0efc291
@dulmandakh dulmandakh deleted the bump-sdk-27 branch August 23, 2018 22:54
aleclarson pushed a commit to aleclarson/react-native that referenced this pull request Sep 16, 2018
…k#20777)

Summary:
I found that android support library 27.x (facebook@874cca1) requires compileSdkVersion to be 27. Also found that many FB projects use SDK 27.
Pull Request resolved: facebook#20777

Differential Revision: D9478431

Pulled By: hramos

fbshipit-source-id: ca100f6b5b39e7d112926124423f9510a0efc291
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
Summary:
I found that android support library 27.x (facebook/react-native@874cca1) requires compileSdkVersion to be 27. Also found that many FB projects use SDK 27.
Pull Request resolved: facebook/react-native#20777

Differential Revision: D9478431

Pulled By: hramos

fbshipit-source-id: ca100f6b5b39e7d112926124423f9510a0efc291
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
rozele pushed a commit to microsoft/react-native-windows that referenced this pull request Apr 14, 2019
Summary:
I found that android support library 27.x (facebook/react-native@874cca1) requires compileSdkVersion to be 27. Also found that many FB projects use SDK 27.
Pull Request resolved: facebook/react-native#20777

Differential Revision: D9478431

Pulled By: hramos

fbshipit-source-id: ca100f6b5b39e7d112926124423f9510a0efc291
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
…k#20777)

Summary:
I found that android support library 27.x (facebook@874cca1) requires compileSdkVersion to be 27. Also found that many FB projects use SDK 27.
Pull Request resolved: facebook#20777

Differential Revision: D9478431

Pulled By: hramos

fbshipit-source-id: ca100f6b5b39e7d112926124423f9510a0efc291
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
…k#20777)

Summary:
I found that android support library 27.x (facebook@874cca1) requires compileSdkVersion to be 27. Also found that many FB projects use SDK 27.
Pull Request resolved: facebook#20777

Differential Revision: D9478431

Pulled By: hramos

fbshipit-source-id: ca100f6b5b39e7d112926124423f9510a0efc291
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants