Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualizedList function optimization #20208

Closed
wants to merge 7 commits into from
Closed

VirtualizedList function optimization #20208

wants to merge 7 commits into from

Commits on Jul 13, 2018

  1. Remove unnecessary re-renders by replacing in-place lambda expression… 

    … with a member function in VirtualList and modify the CellRenderer to pass its attributes back up.
    @jasekiw
    jasekiw committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    62c512e View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2018

  1. Make the CellRenderer a pure component.

    @jasekiw
    jasekiw committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    aab9d15 View commit details
    Browse the repository at this point in the history

  2. Change CellRenderer back from PureComponent to Component and implemen… 

    …t shouldComponentUpdate. Apply shallowEqual on props excluding parentProps, shallowEqual on parentProps, and shallowEqual on state.
    @jasekiw
    jasekiw committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    3697edd View commit details
    Browse the repository at this point in the history

  3. Change CellRenderer back from PureComponent to Component.

    @jasekiw
    jasekiw committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    8cf876f View commit details
    Browse the repository at this point in the history

  4. Fix flow errors.

    @jasekiw
    jasekiw committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    ac4f416 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2018

  1. Add onLayout guard.

    @jasekiw
    jasekiw committed Jul 28, 2018
    Configuration menu
    Copy the full SHA
    03e3eb4 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/virtuallist-function-optimizatio… 

    …n' into virtuallist-function-optimization
    @jasekiw
    jasekiw committed Jul 28, 2018
    Configuration menu
    Copy the full SHA
    f194e7c View commit details
    Browse the repository at this point in the history