limit Android NDK jobs on CI #19747
Closed
limit Android NDK jobs on CI #19747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
✅Test Plan
Missing Changelog
|
aHa, That's why. My first thought is the gradle need more memeory. |
gengjiawen
reviewed
Jun 16, 2018
ReactAndroid/build.gradle
Outdated
| @@ -221,7 +222,7 @@ task buildReactNdkLib(dependsOn: [prepareJSC, prepareBoost, prepareDoubleConvers | |||
| "THIRD_PARTY_NDK_DIR=$buildDir/third-party-ndk", | |||
| "REACT_COMMON_DIR=$projectDir/../ReactCommon", | |||
| '-C', file('src/main/jni/react/jni').absolutePath, | |||
| '--jobs', project.hasProperty("jobs") ? project.property("jobs") : Runtime.runtime.availableProcessors() | |||
| '--jobs', ndkJobs ?: project.hasProperty("jobs") ? project.property("jobs") : Runtime.runtime.availableProcessors() | |||
There was a problem hiding this comment.
With two ?: this looks a little confusing, maybe split it up. Are you revert to jobs if ndkJobs not defined ?
There was a problem hiding this comment.
Just one ?: which means
value ?: default then default value is ternary operator.
'--jobs', ndkJobs ?: project.hasProperty("jobs") ? project.property("jobs") : Runtime.runtime.availableProcessors()
Means get ndkJobs value or check if project has "jobs" property then get it's value or Runtime.runtime.availableProcessors()
|
@hramos Please review and merge 😉 |
|
clean version #19755 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit number of NDK jobs of ReactAndroid on CI using $BUILD_THREADS environment variable. Otherwise, it was spawning 32 jobs while building RNTester, which caused in OOM or unexpected failure.
CI: https://circleci.com/gh/dulmandakh/react-native/322
Test Plan
Android CI is green again 😍