-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable edge antialiasing only for transforms with perspective #19360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sorry to ask, can you rebase? It's been a long time since the PR was opened (our bad!) and we need to rebase your changes on top of a more recent commit in order to import them. After you pull the latest master, you can run the following on your branch:
|
Enable edge antialiasing only for transforms with perspective remove dead store Update RCTViewManager.m
1ddedab
to
72730fb
Compare
@hramos I have done rebase, any else I can do? |
That’s it! I’ll try re importing tomorrow after looking into the CI failures. Sent with GitHawk |
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
I opened a new diff on Phabricator to work around the import issues. Once that diff gets approved and merged, the bot will comment on this PR. |
@zhongwuzw merged commit cbf65f2 into |
Test Plan
Tested under
iPhone6+
and simulator, testperspective
andskew*
props ofView
.The
jag
only happed whenm34
oftransform
is not equal to0.0f
.Related PRs
No related PRs.
Changelog
[iOS] [Added] - RCTViewManager: Enable edge antialiasing only for transforms with perspective.