Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable edge antialiasing only for transforms with perspective #19360

Closed
wants to merge 1 commit into from

Conversation

zhongwuzw
Copy link
Contributor

@zhongwuzw zhongwuzw commented May 20, 2018

Test Plan

Tested under iPhone6+ and simulator, test perspective and skew* props of View.
The jag only happed when m34 of transform is not equal to 0.0f.

Related PRs

No related PRs.

Changelog

[iOS] [Added] - RCTViewManager: Enable edge antialiasing only for transforms with perspective.

@zhongwuzw zhongwuzw requested a review from shergin as a code owner May 20, 2018 13:35
@react-native-bot react-native-bot added the Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. label May 20, 2018
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2018
@react-native-bot react-native-bot added ✅Test Plan Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature. and removed Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels May 20, 2018
@facebook facebook deleted a comment from facebook-github-bot Feb 13, 2019
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 13, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hramos
Copy link
Contributor

hramos commented Feb 13, 2019

Sorry to ask, can you rebase? It's been a long time since the PR was opened (our bad!) and we need to rebase your changes on top of a more recent commit in order to import them.

After you pull the latest master, you can run the following on your branch:

git rebase -i 7d741d1119532213e2c30707320351fb56c63953

Enable edge antialiasing only for transforms with perspective

remove dead store

Update RCTViewManager.m
@zhongwuzw
Copy link
Contributor Author

@hramos I have done rebase, any else I can do?

@hramos
Copy link
Contributor

hramos commented Feb 14, 2019

That’s it! I’ll try re importing tomorrow after looking into the CI failures.

Sent with GitHawk

@facebook-github-bot facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 14, 2019
@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@hramos
Copy link
Contributor

hramos commented Feb 14, 2019

I opened a new diff on Phabricator to work around the import issues. Once that diff gets approved and merged, the bot will comment on this PR.

@react-native-bot
Copy link
Collaborator

@zhongwuzw merged commit cbf65f2 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Feb 15, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs: Rebase Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants