[PickerIOS] fix missing selection indicator lines

[VSchlattinger]

Motivation

This PR is based on #13342 by @pvinis and fixes #14442.

As suggested in the discussion on the PR mentioned above, I moved the code from React/Views/RCTPickerManager.m to the initWithFrame function in React/Views/RCTPicker.m and verified that it still fixes the problem.

Test Plan

Before the change in this PR the selection indicator lines are missing when the Picker is initially added to the View and only appear after changing to a different Tab and back. This happens both in the Simulator and my real device (iPhone 6S on iOS 11.3).

After the change, the indicator lines always appear. I did not notice any side effects of this change when playing around with the Picker in different configurations.

Related PRs

#13342 also fixes this issue but appears to be inactive.

Release Notes

[IOS] [BUGFIX] [PickerIOS] - Fixed missing selection indicator lines

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

@VSchlattinger I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

[VSchlattinger]

@shergin Can you review (and merge) this PR? Otherwise, please ping someone who has worked on this Component before and can do a review.

[VSchlattinger]

@hramos @shergin Is there anything I can do to help this PR get merged soon? What is holding it back?

[janicduplessis]

@VSchlattinger Could you rebase on master to get tests passing? Then I can land this as it seems you addressed all feedback left on the previous PR.

[VSchlattinger]

@janicduplessis Thank you for your reply.

I just rebased on the current master but test_end_to_end still fails…

[janicduplessis]

@VSchlattinger Thanks, it's failing on master too so this is fine.

@facebook-github-bot shipit

[facebook-github-bot]

@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was closed by @VSchlattinger in e592d6f.

Once this commit is added to a release, you will see the corresponding version tag below the description at e592d6f. If the commit has a single master tag, it is not yet part of a release.