Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This ensures no illegal cookies are send to okhttp #18203

Closed
wants to merge 9 commits into from

Commits on Mar 5, 2018

  1. This ensures no illegal cookies are send to okhttp

    When a website in a ReactNative WebView sets a cookie with an illegal
    character, this cookie will automatically be added to any request to the
    same domain.
    
    This happens through:
    BridgeInterceptor.java (l.84)
    ReactCookieJarContainer.java (l.44)
    JavaNetCookieJar.java (l.59)
    ForwardingCookieHandler.java (l.57)
    ForwardingCookieHandler.java (l.168)
    CookieManager.java (l.39)
    
    The BridgeInterceptor.java then tries to set a Cookie header, which
    validates both keys and values, and then crashes.
    okhttp3.6.0 Headers.java (l.320)
    
    This fix will strip illegal characters from any cookie that is being
    passed to the okhttp request.
    Erik Poort committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    b9e6165 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2018

  1. Configuration menu
    Copy the full SHA
    06e886e View commit details
    Browse the repository at this point in the history
  2. Add tests for ReactCookieJarContainer

    This will test the filtering of invalid cookies that might be set
    through the Android WebView.
    Erik Poort committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    f523fc4 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'upstream/master'

    * upstream/master:
      Local cli/android/normalize project name
    Erik Poort committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    295c577 View commit details
    Browse the repository at this point in the history
  4. Fix confusing typo

    Erik Poort committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    ab9f91c View commit details
    Browse the repository at this point in the history
  5. Remove unused classes and annotations

    Erik Poort committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    182fdc4 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2018

  1. Merge branch 'upstream/master'

    * upstream/master:
      Fix Android job
      Enable obfuscation in ProGuard rules by default
      Add a way to dismiss PopupMenu elements
      Simplify templates
      Explicitly set path to yarn
      Prevent show a hidden status bar when opening modals, fix facebook#7474
    Erik Poort committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    b538d80 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2018

  1. Merge branch 'upstream/master'

    * upstream/master: (290 commits)
      Bump babel-preset-react-native version to 5.0.0 for Babel 7
      Upgrade Prettier to v1.12.1 on fbsource
      Make Spacing cloneable
      Fix BadtokenException thrown when opening Android Catalyst app
      Fix crash when reloading with Perf Monitor enabled
      Remove extra space in source_files
      Forked RN renderers for FB and OSS (52afbe0...0887c7d)
      Fix OSS Fabric test build
      Use real YogaNodes in FabricReconcilerTest
      Bump metro@0.33.0
      Add getParent() method for easier migration
      Use real YogaNodes in FabricUIManagerTest
      Display JS component stack in native view exceptions
      Add devDependencies support for templates
      Move Fabric tests to OSS
      Pass drawable width and height in pixels for inline image
      Switch equality check in BlobModule.java
      cxxreact/RAMBundleRegistry: nit fixes
      cxxreact/RAMBundleRegistry: prepend segment ID
      Revert D7569885: Fix anti aliasing rounded background
      ...
    Erik Poort committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    1642583 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2018

  1. Merge branch 'upstream/master'

    * upstream/master: (298 commits)
      Fabric: Support for object notation in dynamic-to-Point/Size/Edges converstions
      Add more fabric logging information
      Wire up event handler bindings
      RN: Fix Reponder Logic in Text
      Remove Native Extensions
      Move Native Extensions from JSContext layer to ContextFactory
      Prevent RefreshControl from getting stuck when a parent is scrolled horizontally
      Remove __fbUninstallRNGlobalErrorHandler
      Bump Metro to 0.37.1
      Re-format BUCK to use recommended style.
      Prettier
      Fabric: Deletion of unused files
      Fix JUnit report location when running Jest
      Fabric: Using unique_ptr for storing YGNode inside YogaLayoutableShadowNode
      Alternative Instance Handle Approach without JSWeakRef
      React sync for revisions de84d5c...c0fe8d6
      Fix typo
      iOS: Introduced ComponentDescriptorFactory to provide app specific component registry
      Bump rn babel preset to 5.0.1
      Add automated script to update the babelHelpers file
      ...
    Erik Poort committed May 22, 2018
    Configuration menu
    Copy the full SHA
    e62f136 View commit details
    Browse the repository at this point in the history