Revert "Better Android Gradle Plugin 3.x integration" #18189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d16ff3b.
facebook-github-bot
added
the
CLA Signed
|
@CFKevinRef If you can find a way that also works with gradle 2.14.1 it would be great. Otherwise I think we'll have to hold on a bit before relanding this. |
Generated by 🚫 dangerJS |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Mar 5, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Not a problem, I do have an idea but will be a few days before I can get back to this. Thanks for the heads up! |
|
@CFKevinRef Thanks! If this is a blocker for anyone it is possible to copy the content of the react.gradle file inside your project and change the plugin apply path to point to that instead of the one under node_modules/react-native. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d16ff3b.
Motivation
Currently breaks with the gradle version used by RN, I think there has been some work to update that to a more recent one but for now I think we should just revert it.
It errors with:
Test Plan
Tested that RN tester now builds when using the right react.gradle (#18188)
Release Notes
[ ANDROID ] [ BUGFIX ] [ react.gradle ] - REVERT "Support Android Gradle Plugin 3.x and AAPT2"
[ ANDROID ] [ FEATURE ] [ react.gradle ] - REVERT "Expose the bundling task and its outputs via ext properties"