Fix onLayout prop for TextInput on Android
#18040
Conversation
When the `autogrow` prop was removed from `TextInput` on Android, the `_onLayout` helper method was removed. This helper method implemented the hook required to make `autogrow` work, then dispatched the `onLayout` event to the handler in `this.props`. This change points passes the `onLayout` handler from `this.props` directly to the inner component.
facebook-github-bot
added
CLA Signed
| @@ -880,7 +880,7 @@ const TextInput = createReactClass({ | |||
|
|
|||
| return ( | |||
| <TouchableWithoutFeedback | |||
| onLayout={this._onLayout} | |||
There was a problem hiding this comment.
can we do this.props.onLayout to maintain equality?
There was a problem hiding this comment.
@chirag04 - this.props is copied into a local variable:
https://github.com/facebook/react-native/blob/master/Libraries/Components/TextInput/TextInput.js#L836
This is exactly how it's done for iOS:
https://github.com/facebook/react-native/blob/master/Libraries/Components/TextInput/TextInput.js#L771
https://github.com/facebook/react-native/blob/master/Libraries/Components/TextInput/TextInput.js#L822
|
Good catch! @facebook-github-bot shipit |
|
Something went wrong executing that command, @hramos could you take a look? |
facebook-github-bot
added
Failed Commands
Import Started
There was a problem hiding this comment.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
When the
autogrowprop was removed fromTextInputon Android, the_onLayouthelper method was removed. This helper method implemented the hook required to makeautogrowwork, then dispatched theonLayoutevent to the handler inthis.props. This change points passes theonLayouthandler fromthis.propsdirectly to the inner component.Motivation
I was updating copied code in react-native-windows and noticed this bug.
Test Plan
Run jest tests.
Related PRs
N/A
Release Notes
[ANDROID][MINOR][BUGFIX] [TextInput] - Fix
onLayoutprop for TextInput on Android