Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add google() to build.gradle in CLI template #17395

Closed
wants to merge 2 commits into from
Closed

add google() to build.gradle in CLI template #17395

wants to merge 2 commits into from

Conversation

riwu
Copy link

@riwu riwu commented Dec 30, 2017

Motivation

Fixes android build issue

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 30, 2017
@pull-bot
Copy link

pull-bot commented Dec 30, 2017 •
edited
Loading

Warnings
⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.
⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

Generated by 🚫 dangerJS

@facebook-github-bot
Copy link
Contributor

@riwu I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@chirag04
Copy link
Contributor

@riwu what problem does this fix specifically? Can you provide a repro?

chirag04
chirag04 reviewed Jan 29, 2018
View reviewed changes
local-cli/templates/HelloWorld/android/build.gradle Outdated
@@ -3,6 +3,7 @@
buildscript {
repositories {
jcenter()
google()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also i think this only works for gradle 4 and up. RN is not using gradle 4 yet.

@riwu
Copy link
Author

riwu commented Jan 30, 2018

Indeed this is only a problem on newer versions of gradle.
See #15756 and this.

Is there documentation on supported versions of gradle?

@react-native-bot react-native-bot added Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. Ran Commands One of our bots successfully processed a command. labels Mar 16, 2018
hramos
hramos suggested changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@hramos hramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge until Gradle version is bumped

@react-native-bot react-native-bot added the Missing Test Plan This PR appears to be missing a test plan. label May 15, 2018
@dulmandakh
Copy link
Contributor

closing this PR because the same change is introduced in 6e35689

@dulmandakh dulmandakh closed this Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag04 chirag04 chirag04 left review comments

@hramos hramos hramos requested changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. Missing Test Plan This PR appears to be missing a test plan. Ran Commands One of our bots successfully processed a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@riwu @pull-bot @facebook-github-bot @chirag04 @dulmandakh @hramos @react-native-bot