Fix ReactLegacy and delete RCTViewControllerProtocol #17290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
@facebook-github-bot label Needs more information @facebook-github-bot label Core Team Attention: @shergin Generated by 🚫 dangerJS |
javache
force-pushed
the
rctvc-protocol
branch
from
6b0c6b2 to
1ec14ab
Compare
|
why wasn't this just a diff 😅 |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 20, 2017
There was a problem hiding this comment.
@mmmulani is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I was lazy and didn't want to get on VPN.. but it looks I'll need to after all. |
vincentriemer
pushed a commit
to vincentriemer/react-native-dom
that referenced
this pull request
Jan 9, 2018
Summary: It's always bothered that we have this protocol and I figured it could just be merged with RCTWrapperViewController. Closes facebook/react-native#17290 Reviewed By: mmmulani Differential Revision: D6611544 Pulled By: javache fbshipit-source-id: a50b9d5adbeb2c48dbadbbfc1c77ccf6d1aae144
mathiasbynens
pushed a commit
to mathiasbynens/react-native
that referenced
this pull request
Jan 13, 2018
Summary: It's always bothered that we have this protocol and I figured it could just be merged with RCTWrapperViewController. Closes facebook#17290 Reviewed By: mmmulani Differential Revision: D6611544 Pulled By: javache fbshipit-source-id: a50b9d5adbeb2c48dbadbbfc1c77ccf6d1aae144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's always bothered that we have this protocol and I figured it could just be merged with RCTWrapperViewController.
Test plan:
Build and Run both RNTester and RNTesterLegacy