Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TextInput "clear text" button accessible #17230

Closed
wants to merge 1 commit into from
Closed

Make TextInput "clear text" button accessible #17230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Libraries/Text/TextInput/Singleline/RCTUITextField.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,22 @@ - (void)setEditable:(BOOL)editable
self.enabled = editable;
}

#pragma mark - Accessibility

- (BOOL)isAccessibilityElement
{
// Always return NO to enumerate child elements. Otherwise the "clear text" button is hidden
// from accessibility interface.
return NO;
}

- (BOOL)accessibilityElementsHidden
{
// If "accessible" prop is set to false on TextInput, disable all accessible children.
// Without this function the "clear text" UIButton is still exposed.
return ![super isAccessibilityElement];
}

#pragma mark - Caret Manipulation

- (CGRect)caretRectForPosition:(UITextPosition *)position
Expand Down