Tell template app .flowconfig to look for .native.js files #16816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`metro-bundler` looks for `.native.js` files ([see here](https://github.com/facebook/metro-bundler/blob/master/packages/metro-bundler/src/node-haste/DependencyGraph/ModuleResolution.js#L458)). Packages such as `react-navigation` rely on this functionality ([see here](https://github.com/react-community/react-navigation/blob/master/src/PlatformHelpers.native.js)). This PR makes it so you can `react-native init`, `yarn add react-navigation`, and `flow` successfully! All four must be specified, since specifying any `module.file_ext` overrides the default three.
facebook-github-bot
added
the
CLA Signed
|
@gabelevi, any chance you could look at this? It's a small change to |
|
@calebmer, could I trouble you to look at this? It's a small change to |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 30, 2017
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: `metro-bundler` looks for `.native.js` files ([see here](https://github.com/facebook/metro-bundler/blob/master/packages/metro-bundler/src/node-haste/DependencyGraph/ModuleResolution.js#L458)). Packages such as `react-navigation` rely on this functionality ([see here](https://github.com/react-community/react-navigation/blob/master/src/PlatformHelpers.native.js)). This PR makes it so you can `react-native init`, `yarn add react-navigation`, and `flow` successfully! 1. `react-native init` 2. `yarn add react-navigation` 3. `flow` [CLI] [MINOR] [Flow] - Tell template app .flowconfig to look for .native.js files Closes facebook#16816 Differential Revision: D6445363 Pulled By: shergin fbshipit-source-id: c0ce7ed27a8a3291deaa09d98e822362f93929c8
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: `metro-bundler` looks for `.native.js` files ([see here](https://github.com/facebook/metro-bundler/blob/master/packages/metro-bundler/src/node-haste/DependencyGraph/ModuleResolution.js#L458)). Packages such as `react-navigation` rely on this functionality ([see here](https://github.com/react-community/react-navigation/blob/master/src/PlatformHelpers.native.js)). This PR makes it so you can `react-native init`, `yarn add react-navigation`, and `flow` successfully! 1. `react-native init` 2. `yarn add react-navigation` 3. `flow` [CLI] [MINOR] [Flow] - Tell template app .flowconfig to look for .native.js files Closes facebook#16816 Differential Revision: D6445363 Pulled By: shergin fbshipit-source-id: c0ce7ed27a8a3291deaa09d98e822362f93929c8
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: `metro-bundler` looks for `.native.js` files ([see here](https://github.com/facebook/metro-bundler/blob/master/packages/metro-bundler/src/node-haste/DependencyGraph/ModuleResolution.js#L458)). Packages such as `react-navigation` rely on this functionality ([see here](https://github.com/react-community/react-navigation/blob/master/src/PlatformHelpers.native.js)). This PR makes it so you can `react-native init`, `yarn add react-navigation`, and `flow` successfully! 1. `react-native init` 2. `yarn add react-navigation` 3. `flow` [CLI] [MINOR] [Flow] - Tell template app .flowconfig to look for .native.js files Closes facebook/react-native#16816 Differential Revision: D6445363 Pulled By: shergin fbshipit-source-id: c0ce7ed27a8a3291deaa09d98e822362f93929c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
metro-bundlerlooks for.native.jsfiles (see here). Packages such asreact-navigationrely on this functionality (see here). This PR makes it so you canreact-native init,yarn add react-navigation, andflowsuccessfully!Test Plan
react-native inityarn add react-navigationflowRelease Notes
[CLI] [MINOR] [Flow] - Tell template app .flowconfig to look for .native.js files