Migrate RCTWebView to WKWebView. #16792

bowerman0 · 2017-11-11T02:06:17Z

Motivation

#321 - Use WKWebView instead of UIWebView, because WKWebView is faster, consumes less memory, and is more stable.

This is meant to be a drop-in replacement for the existing UIWebView-based RCTWebView.

Test Plan

Used a web view loosely based on RNTester's WebViewExample.js, and tested in an ejected AwesomeProject. Browsed around the internet.

Release Notes

[IOS][ENHANCEMENT][RCTWebView] - Migrate RCTWebView to use WKWebView instead of UIWebView.

pull-bot · 2017-11-11T02:07:26Z

Attention: @shergin

Generated by 🚫 dangerJS

bowerman0 · 2017-11-15T19:46:19Z

Is there some way to test/fix the flow check locally? I did not change any JavaScript code in this PR, so I am not sure how this broke it.

node 6:

npm info lifecycle react-native@1000.0.0~flow: react-native@1000.0.0

react-native@1000.0.0 flow /home/circleci/react-native
flow "check"

Error: node_modules/metro-bundler/src/Bundler/util.js.flow:46
46: ): Ast {
^^^ identifier Ast. Could not resolve name

Found 1 error

npm info lifecycle react-native@1000.0.0~flow: Failed to exec flow script
npm ERR! Linux 4.4.0-97-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "flow" "--" "check"
npm ERR! node v6.11.0
npm ERR! npm v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! react-native@1000.0.0 flow: flow "check"
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the react-native@1000.0.0 flow script 'flow "check"'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the react-native package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! flow "check"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs react-native
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls react-native
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! /home/circleci/react-native/npm-debug.log

and node 8:

react-native@1000.0.0 flow /home/circleci/react-native
flow "check"

Error: node_modules/metro-bundler/src/Bundler/util.js.flow:46
46: ): Ast {
^^^ identifier Ast. Could not resolve name

Found 1 error
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! react-native@1000.0.0 flow: flow "check"
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the react-native@1000.0.0 flow script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! /home/circleci/.npm/_logs/2017-11-11T19_25_11_051Z-debug.log
Exited with code 2

randyzhao · 2017-11-22T21:37:00Z

This looks really awesome. Thanks for working on it.

BTW, not only is WKWebview faster, consumes less memory and stable, but it's also required by Apple now.

Starting in iOS 8.0 and OS X 10.10, use WKWebView to add web content to your app. Do not use UIWebView or WebView.

https://developer.apple.com/documentation/webkit/wkwebview

bowerman0 · 2017-12-05T18:47:28Z

Thanks @randyzhao! I'd love to hear any issues that you (or anyone else) run into with the WKWebView version of RCTWebView.

grabbou · 2018-01-04T16:18:28Z

Thanks for the PR. It's quite big, so let me get attention from few more people.

CC: @ide - I think there was an idea of moving WebView outside of React Native as its not extensively used at Facebook? If not, apologies, I probably confused that with another component.

ide · 2018-01-04T23:54:34Z

@grabbou possibly, since we'd like to increase the React Native repo's focus on truly core parts like the C++ bridge.

facebook-github-bot · 2018-01-05T18:04:15Z

@bowerman0 I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

pull-bot · 2018-02-06T17:40:00Z

	Warnings
⚠️	❗ Big PR - This PR is extremely unlikely to get reviewed because it touches 604 lines.

@facebook-github-bot large-pr

Attention: @shergin

Generated by 🚫 dangerJS

bowerman0 · 2018-02-06T17:47:24Z

@ide @grabbou Should the web view move into a standalone module?

grabbou · 2018-02-08T09:30:44Z

That's my understanding. Also, there's already quite interesting community implementation, called react-native-wkwebview that I've been using myself.

zachrip · 2018-02-08T23:04:25Z

@bowerman0 @grabbou @ide one reason I'd like to see this hit rn is so that expo will have it without having to eject. So either it'd need to be supported by the expo team (they pull in some modules like this I guess) or it'd have to go in here (in order to use it in expo without ejecting). https://expo.canny.io/feature-requests/p/wkwebview-support - as you can see the request is pretty low in priority :/

jh97uk · 2018-02-09T01:02:55Z

Any updates from the React team on this? This is a crucial part of my app and it would be awesome to not have to eject my expo app.

grabbou · 2018-02-11T23:29:48Z

I am pretty sure WebView will remain part of Expo regardless, but you can ask this on their support forum just in case :)

…

On Fri, 9 Feb 2018 at 02:04 James Heald ***@***.***> wrote: Any updates from the React team on this? This is a crucial part of my app and it would be awesome to *not* have to eject my expo app. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16792 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxjv5Otn7o2J2gjSh1rxIL_qEFpyQks5tS5mPgaJpZM4QaUMH> .

facebook-github-bot · 2018-03-08T18:04:56Z

@bowerman0 I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

jh97uk · 2018-03-08T18:09:40Z

@grabbou sadly they aren't supportive of implementing it :( . Hopefully React Native gets it soon!

Especially as WebView on iOS is buggy slow and I also wonder about how secure it is given its deprecated since iOS 8.

hpmax00 · 2018-08-06T05:36:48Z

Any updates for this pr?

RSNara · 2018-10-12T22:53:36Z

A new WKWebView implementation was recently merged into this repository, and then extracted to react-native-webview. Since this PR seems to be addressing a problem that was already solved, I'm going to close it.

…ted UIWebView error from app store - Problem - Email after upload: `ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs` - Our react-native is really old and still has RCTWebView - Solution - Rip out RCTWebView - `find node_modules/react-native/ | grep RCTWebView | xargs trash` - From facebook/react-native#26255 (comment) - Future react-native versions move WebView out to https://github.com/react-native-community/react-native-webview - facebook/react-native#16792 (comment)

bowerman0 requested a review from shergin as a code owner November 11, 2017 02:06

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2017

bowerman0 force-pushed the master branch from ce4ee3f to 7d1bbd1 Compare November 24, 2017 20:20

bowerman0 mentioned this pull request Nov 30, 2017

WIP: migrate <WebView> from UiWebView to WKWebView in iOS #16535

Closed

bowerman0 force-pushed the master branch from 7d1bbd1 to da2cf97 Compare December 5, 2017 18:03

bowerman0 requested review from grabbou, hramos, janicduplessis, Kureev and mhorowitz as code owners December 5, 2017 18:14

bowerman0 force-pushed the master branch 2 times, most recently from ca5d6f6 to 4fe455f Compare December 5, 2017 18:28

borisyankov mentioned this pull request Jan 8, 2018

Consider using WKWebView zulip/zulip-mobile#1716

Closed

fossecode mentioned this pull request Jan 19, 2018

Use WKWebView instead of UIWebView #321

Closed

bowerman0 added 2 commits February 6, 2018 09:37

Migrate RCTWebView to WKWebView.

4998ebb

Enable scroll events for RCTWebView

fbabeff

bowerman0 force-pushed the master branch from 4fe455f to fbabeff Compare February 6, 2018 17:38

react-native-bot added Feature Request 🌟 Platform: iOS iOS applications. Ran Commands One of our bots successfully processed a command. labels Mar 16, 2018

hramos added Type: Enhancement A new feature or enhancement of an existing feature. and removed 🌟Feature Request labels Mar 19, 2018

johncblandii mentioned this pull request Jun 8, 2018

iOS: WebView stays in loading state #19617

Closed

luisnaranjo733 mentioned this pull request Aug 1, 2018

UIWebView is formally deprecated in the upcoming iOS 12 microsoft/reactxp#765

Closed

RSNara closed this Oct 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate RCTWebView to WKWebView. #16792

Migrate RCTWebView to WKWebView. #16792

bowerman0 commented Nov 11, 2017 •

edited

Loading

pull-bot commented Nov 11, 2017 •

edited

Loading

bowerman0 commented Nov 15, 2017

randyzhao commented Nov 22, 2017 •

edited

Loading

bowerman0 commented Dec 5, 2017

grabbou commented Jan 4, 2018

ide commented Jan 4, 2018

facebook-github-bot commented Jan 5, 2018

pull-bot commented Feb 6, 2018

bowerman0 commented Feb 6, 2018

grabbou commented Feb 8, 2018

zachrip commented Feb 8, 2018

jh97uk commented Feb 9, 2018

grabbou commented Feb 11, 2018 via email

facebook-github-bot commented Mar 8, 2018

jh97uk commented Mar 8, 2018

hpmax00 commented Aug 6, 2018

RSNara commented Oct 12, 2018

Migrate RCTWebView to WKWebView. #16792

Migrate RCTWebView to WKWebView. #16792

Conversation

bowerman0 commented Nov 11, 2017 • edited Loading

Motivation

Test Plan

Release Notes

pull-bot commented Nov 11, 2017 • edited Loading

bowerman0 commented Nov 15, 2017

randyzhao commented Nov 22, 2017 • edited Loading

bowerman0 commented Dec 5, 2017

grabbou commented Jan 4, 2018

ide commented Jan 4, 2018

facebook-github-bot commented Jan 5, 2018

pull-bot commented Feb 6, 2018

bowerman0 commented Feb 6, 2018

grabbou commented Feb 8, 2018

zachrip commented Feb 8, 2018

jh97uk commented Feb 9, 2018

grabbou commented Feb 11, 2018 via email

facebook-github-bot commented Mar 8, 2018

jh97uk commented Mar 8, 2018

hpmax00 commented Aug 6, 2018

RSNara commented Oct 12, 2018

bowerman0 commented Nov 11, 2017 •

edited

Loading

pull-bot commented Nov 11, 2017 •

edited

Loading

randyzhao commented Nov 22, 2017 •

edited

Loading