Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Text] Get the system font instead of Helvetica programmatically and add a virtual fontName called "System" #1635

Closed
wants to merge 3 commits into from
Closed

[Text] Get the system font instead of Helvetica programmatically and add a virtual fontName called "System" #1635

wants to merge 3 commits into from

Commits on Jun 17, 2015

  1. [Text] Get the system font instead of Helvetica programmatically. 

    Summary:
Get the system font instead of Helvetica programmatically.
    @dalinaum
    dalinaum committed Jun 17, 2015
    Configuration menu
    Copy the full SHA
    d36de67 View commit details
    Browse the repository at this point in the history

  2. [Text] Add a virtual fontName called "System". 

    Add a virtual fontName called "System" that defaults to whatever the
current system font is. (@nicklockwood facebook#1611)

It may break UI of existing apps.
    @dalinaum
    dalinaum committed Jun 17, 2015
    Configuration menu
    Copy the full SHA
    96e4f04 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2015

  1. [Text] RCTConvert uses fontDescriptor of System font or given fonts. 

     * All font + weight/fontName -> It uses familyName to generate font.
 * System font -> It uses fontDescriptor to generate font.
 * Other font -> uses fontDescriptor to getnere font.

It looks like iOS doesn't support changing weight dynamically.
System font with weight is supported iOS 8.2 and later.
    @dalinaum
    dalinaum committed Jun 19, 2015
    Configuration menu
    Copy the full SHA
    3ca2f73 View commit details
    Browse the repository at this point in the history