Network Inspector - convert list view to flat list #15548
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
AlanFoster
force-pushed
the
network-overlay-convert-list-view-to-flat-list
branch
from
a081831
to
b3b35f4
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
cc @lebronJ - I think you might have some opinions on this PR :) |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
AlanFoster
force-pushed
the
network-overlay-convert-list-view-to-flat-list
branch
from
b3b35f4
to
a348758
Compare
|
The travis test failures seem unrelated; I've rebased this against master too :) |
|
@janicduplessis Thanks for the help shipping the flash indicators effort! :) Would love a review on this ground work, as I'll be putting up some additional PRs to improve the developer experience for the inbuilt network tab after this :) |
AlanFoster
force-pushed
the
network-overlay-convert-list-view-to-flat-list
branch
from
a348758
to
f2cdf5a
Compare
| this._captureDetailScrollView = this._captureDetailScrollView.bind(this); | ||
| this._listViewOnLayout = this._listViewOnLayout.bind(this); |
There was a problem hiding this comment.
property _renderItem Covariant property _renderItem incompatible with contravariant use in assignment of property _renderItem
|
Just to help with review and getting this out, I'll close this PR in favour of the combined PR which additionally has the improved scroll functionality: |
AlanFoster
deleted the
network-overlay-convert-list-view-to-flat-list
branch
ListView is marked as deprecated in the latest react-native code:
I wanted to help out by migrating Network Inspector's existing ListView component to use the new FlatList component
Test Plan
Ensured that the same functionality worked for both XHR, and WS scenarios, and compared before and after:
Before
After
The only visual difference is the chosen row colors, and replacing the border highlight with a different background color.