Corrected types of page_info return
#15472
Conversation
`page_info` has `start_cursor` and `end_cursor` which are currently marked in the docs as `boolean` type, but they're actually strings.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
@blargity I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
@blargity sorry i messed up the rebase. Can you rebase real quick and i will land it? |
|
@blargity I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
Summary: I was confused by the current documentation, as it was requesting me to pass the previously received `end_cursor` into the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs. I tried to push this change back in #15472 but wasn't able to undo the borked rebase, so I'm submitting a new PR. This is a change to documentation only. [DOCS] [BUGFIX] [Libraries/CameralRoll/CameraRoll.js] - Corrected return type in the documentation for the `start_cursor` and `end_cursor` values. Closes #16830 Differential Revision: D6371585 Pulled By: hramos fbshipit-source-id: 5038041e95a04ea4c2de8d2b535a8a4e019289f6
Summary: I was confused by the current documentation, as it was requesting me to pass the previously received `end_cursor` into the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs. I tried to push this change back in facebook#15472 but wasn't able to undo the borked rebase, so I'm submitting a new PR. This is a change to documentation only. [DOCS] [BUGFIX] [Libraries/CameralRoll/CameraRoll.js] - Corrected return type in the documentation for the `start_cursor` and `end_cursor` values. Closes facebook#16830 Differential Revision: D6371585 Pulled By: hramos fbshipit-source-id: 5038041e95a04ea4c2de8d2b535a8a4e019289f6
Summary: I was confused by the current documentation, as it was requesting me to pass the previously received `end_cursor` into the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs. I tried to push this change back in facebook#15472 but wasn't able to undo the borked rebase, so I'm submitting a new PR. This is a change to documentation only. [DOCS] [BUGFIX] [Libraries/CameralRoll/CameraRoll.js] - Corrected return type in the documentation for the `start_cursor` and `end_cursor` values. Closes facebook#16830 Differential Revision: D6371585 Pulled By: hramos fbshipit-source-id: 5038041e95a04ea4c2de8d2b535a8a4e019289f6
page_infohasstart_cursorandend_cursorwhich are currently marked in the docs asbooleantype, but they're actually strings.I was confused by the current documentation, as it was requesting me to pass the previously received
end_cursorinto the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs.Test Plan
This is a change to documentation only.