-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix format specifier used in RCTUIManager #15414
Conversation
Here, `reactTag` is an `NSNumber *` which uses `%@` as the format specifier. Newer versions of clang can warn or error on this. This change prevents that from happening.
Thanks! FYI, you can just submit these internally too. |
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
@kastiglione Uh, really? I believe |
@shergin sounds like you agree with this change from |
@javache why did this fail? |
Just some internal flakiness. It's been merged now. |
@kastiglione Yeah, I misread the diff... Sorry for the mess. |
Here,
reactTag
is anNSNumber *
which uses%@
as the format specifier. Newer versions of clang can warn or error on this. This change prevents that from happening.See also #15402
Test Plan
Local builds with clang 5.