Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format specifier used in RCTUIManager #15414

Closed
wants to merge 1 commit into from

Conversation

kastiglione
Copy link
Contributor

Here, reactTag is an NSNumber * which uses %@ as the format specifier. Newer versions of clang can warn or error on this. This change prevents that from happening.

See also #15402

Test Plan

Local builds with clang 5.

Here, `reactTag` is an `NSNumber *` which uses `%@` as the format specifier. Newer versions of clang can warn or error on this. This change prevents that from happening.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Aug 8, 2017
@pull-bot
Copy link

pull-bot commented Aug 8, 2017

Attention: @shergin, @javache

Generated by 🚫 dangerJS

@javache
Copy link
Member

javache commented Aug 8, 2017

Thanks! FYI, you can just submit these internally too.

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Aug 8, 2017
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@facebook-github-bot facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Aug 9, 2017
@shergin
Copy link
Contributor

shergin commented Aug 9, 2017

@kastiglione Uh, really? I believe %@ notation indicates here that we want to use description method of Objective-C object to generate string representation of the number, whereas %zd will simply print the pointer address to the object (which is actually useless information).

@kastiglione
Copy link
Contributor Author

@shergin sounds like you agree with this change from %zd (useless) to %@?

@kastiglione
Copy link
Contributor Author

@javache why did this fail?

@javache
Copy link
Member

javache commented Aug 9, 2017

Just some internal flakiness. It's been merged now.

@kastiglione kastiglione deleted the patch-2 branch August 9, 2017 17:11
@shergin
Copy link
Contributor

shergin commented Aug 9, 2017

@kastiglione Yeah, I misread the diff... Sorry for the mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants