Support for preventing swipe left or swipe right #14684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary use case for this is disabling swipe right when using react-navigation's swipe to go back feature.
facebook-github-bot
added
CLA Signed
|
I'd appreciate suggestions on how to provide a solid test plan for this...it's a pretty minor change. |
sahrens
approved these changes
Jul 8, 2017
facebook-github-bot
added
GH Review: accepted
Import Started
|
@sahrens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
There is already a way to prevent the "swipe to go back" functionality in React Navigation. See |
|
@migueloller That isn't the intention. Swipe to go back should still work when used in conjunction with the experimental swipe-able cells. That's not currently the case. Hold on approval though please. I'd like to double check no further amends were made to this. |
lprhodes
added a commit
to lprhodes/react-native
that referenced
this pull request
Jul 8, 2017
I had fixed this locally but not updated the original pull request, sorry. This commit is working for us in production.
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 1, 2017
Summary: I had fixed this locally but hadn't updated the original pull request, sorry. This commit is working for us in production. Closes #14900 Differential Revision: D5539787 Pulled By: hramos fbshipit-source-id: 6c826ada4a7f36607c65508ced6c9dce32002f74
grabbou
pushed a commit
that referenced
this pull request
Aug 16, 2017
Summary: I had fixed this locally but hadn't updated the original pull request, sorry. This commit is working for us in production. Closes #14900 Differential Revision: D5539787 Pulled By: hramos fbshipit-source-id: 6c826ada4a7f36607c65508ced6c9dce32002f74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary use case for this is disabling swipe right when using react-navigation's swipe to go back feature.