Removing test-driver symlink in ios third party install script #14638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ios-install-third-party script installs google glog library it creates a symlinks that breaks production release bundeling
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Can you do this as part of |
When ios-install-third-party script installs google glog library it creates a symlinks that breaks production release bundeling
facebook-github-bot
added
GH Review: accepted
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
grabbou
pushed a commit
that referenced
this pull request
Jul 17, 2017
Summary: After execution of `scripts/ios-install-third-party.sh` a symlink is created : `<YOUR-APP-PATH>/node_modules/react-native/third-party/glog-0.3.4/test-driver` that is pointing to `test-driver -> /usr/share/automake-1.14/test-driver` This can be executed indirectly by `react-native run-ios`. This breaks the bundle process if the system don't contain a given file under the link and having this strict dependency on the system setup is not a good practice. Once the `test-driver` symlink is created android app release is failing, for : `./gradlew assembleRelease` the `:app:bundleReleaseJsAndAssets` returns : ``` FAILURE: Build failed with an exception. * What went wrong: Could not list contents of '<YOUR-APP-PATH>/node_modules/react-native/third-party/glog-0.3.4/test-driver'. Couldn't follow symbolic link. ``` Related issues: #14417 #14464 #14548 1. Create new project with `react-native init <YOUR-APP>` 2. cd `<YOUR-APP>/` 3. Run app on iOS `react-native run-ios` so `scripts/ios-install-third-party.sh` is executed. 4. cd `android/` 5. Run android app release `./gradlew assembleRelease` (it will work properly after this fix and fail if the `test-driver` symlink exists) IMHO we should resolve the issue with this quick fix and apply the proper fix later after the new version of `google/glog` will be released. The proper cleanup of files generated by autotools was already applied : google/glog#188 Please let me know if I should provide more details : javache, mhorowitz, hramos Closes #14638 Differential Revision: D5292362 Pulled By: javache fbshipit-source-id: 81ff2273420ea078d624a76e781a5b67b96e6a4e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation (required)
After execution of
scripts/ios-install-third-party.sha symlink is created :<YOUR-APP-PATH>/node_modules/react-native/third-party/glog-0.3.4/test-driverthat is pointing to
test-driver -> /usr/share/automake-1.14/test-driverThis can be executed indirectly by
react-native run-ios.This breaks the bundle process if the system don't contain a given file under the link and having this strict dependency on the system setup is not a good practice.
Once the
test-driversymlink is created android app release is failing, for :./gradlew assembleReleasethe
:app:bundleReleaseJsAndAssetsreturns :Related issues:
#14417
#14464
#14548
Test Plan (required)
react-native init <YOUR-APP><YOUR-APP>/react-native run-iossoscripts/ios-install-third-party.shis executed.android/./gradlew assembleRelease(it will work properly after this fix and fail if thetest-driversymlink exists)Summary
IMHO we should resolve the issue with this quick fix and apply the proper fix later after the new version of
google/glogwill be released.The proper cleanup of files generated by autotools was already applied : google/glog#188
Please let me know if I should provide more details : @javache, @mhorowitz, @hramos