Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc warning stating that TouchableOpacity can only support a single child #1395

Merged
merged 1 commit into from
May 26, 2015
Merged

Add doc warning stating that TouchableOpacity can only support a single child #1395

merged 1 commit into from
May 26, 2015

Conversation

pwmckenna
Copy link
Contributor

screen shot 2015-05-24 at 5 15 31 pm

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 25, 2015
@pwmckenna
Copy link
Contributor Author

addresses #1354

@ide
Copy link
Contributor

ide commented May 26, 2015

This looks good in spirit. I might trim the content for brevity, something like

NOTE: TouchableOpacity supports only one child
If you wish to have to have several child components, wrap them in a View.

@pwmckenna pwmckenna force-pushed the touchableopacitysinglechilddocs branch from b482644 to 0466bbd Compare May 26, 2015 05:03
@pwmckenna
Copy link
Contributor Author

Update:
screen shot 2015-05-25 at 10 04 11 pm

@ide
Copy link
Contributor

ide commented May 26, 2015

lgtm

ide pushed a commit that referenced this pull request May 26, 2015
Merge pull request #1395 from pwmckenna/touchableopacitysinglechilddocs
64ae42c 
Add doc warning stating that TouchableOpacity can only support a single child
@ide ide merged commit 64ae42c into facebook:master May 26, 2015
ayushjainrksh pushed a commit to MLH-Fellowship/react-native that referenced this pull request Jul 2, 2020
@matthew-was @rickhanlonii
Fix linting for versioned_docs/version-0.20 (facebook#1395)
acc60df 
* fixed versioned_docs/version-0.20

* re add 0.19 to alexignore to test just this pr
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2022
Open
@bumplzz69 bumplzz69 mentioned this pull request Sep 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwmckenna @ide @facebook-github-bot