Include Create React Native App in Getting Started #13303

anp · 2017-04-04T22:44:14Z

Motivation

Create React Native App was designed to reduce "time to hello world" to 5-10 minutes for React Native apps. This PR would make CRNA the first way to get started that new users encounter. Included also is some text to help advanced users navigate the question of whether to use CRNA or whether to go straight to react-native init. It also includes a new banner for the iOS and Android guides, since they do not apply to CRNA users.

Test Plan

Changes are only to the website, screenshots below. This branch was created from the last CI-passing master commit this morning, dependencies were freshly installed and these screenshots are from a clean build.

The Getting Started page

The "native builds only" banner

Pages which still apply to CRNApps have no banner

TODO before merging

anp · 2017-04-04T22:44:56Z

docs/GettingStarted.md

-want to develop for both iOS and Android, that's fine - you just have to pick
+## Quick Start
+
+[Create React Native App](https://github.com/react-community/create-react-native-app) is the easiest way to start building a new React Native application. It allows you to start a project without installing or configuring any native build tools.


This phrasing is meant to mirror Create React App's in the React docs, but is fungible as far as I'm concerned.

anp · 2017-04-04T22:45:20Z

docs/GettingStarted.md

+
+[Create React Native App](https://github.com/react-community/create-react-native-app) is the easiest way to start building a new React Native application. It allows you to start a project without installing or configuring any native build tools.
+
+Assuming that you have Node installed, no Xcode or Android Studio installation is required:


Technically CRNA supports Node 6 or higher, not sure it's worth specifying here due to risk of bitrot.

The phrasing here seems a bit odd to me (but keep in mind, English is my second language). The way I read it, Xcode or Android Studio may be required if I don't have Node installed.
Maybe we can split into two sentences, and swap the order? Something like:

No Xcode or Android Studio installation is required. Assuming that you have Node installed, you can run the following commands to create a new React Native projected called "AwesomeProject":

I'm mirroring the instructions for Native Builds at the end here, "AwesomeProject" could be anything but ideally it would match the original RN init commands.

After this PR gets merged I'll probably take another pass at updating the Getting Started guide and subsequent pages, as I'd like to update the tutorial so that it builds on top of the CRNA started project similar to what we did at F8 this year.

That's a good point -- writing for ESL audiences is not my strength.

anp · 2017-04-04T22:46:17Z

docs/GettingStarted.md

+
+Once you've created your project and opened it in the Expo client app, you can proceed to the [Tutorial](docs/tutorial.html).
+
+### Caveats


I think having this as a subsection makes sense because we want to surface the information for advanced users (read: the ones who are willing to read more than 3 sentences due to existing investment) early on without muddying the waters for really new people.

Very open to suggestions on the structure of this though.

Ideally we'd have a standalone CRNA doc that covers any caveats, as well as the ejection process. We can tackle that in a different PR though, I'm OK with this section here for now.

I'll make a note to follow up with you on that after you're back.

anp · 2017-04-04T22:47:09Z

docs/GettingStarted.md

+
+### Caveats
+
+Because you don't build any native code with Create React Native App, it's not possible to include custom native modules beyond the React Native APIs and components that are available in the Expo client app.


Technically this includes the Expo SDK as well, but there's a tradeoff here:

don't want to have to educate new users too much about all of these distinctions

users may not use CRNA if they believe that there's not enough in the client to experiment with

I think it's OK to favor the former over the latter, myself.

Looks good to me, once we have a CRNA doc we can be more verbose there.

anp · 2017-04-04T22:47:59Z

docs/GettingStarted.md

+
+If you're integrating React Native into an existing project, you'll want to skip Create React Native App and go directly to setting up the native build environment. See below for instructions on configuring a native build environment for React Native.
+
+<hr style="margin-top:25px"/>


halp i'm trapped in 1999 and can't get out

brentvatne · 2017-04-05T00:12:20Z

PermissionsAndroid may be flaky in the Expo client, I can't recall (cc @jesseruder)

We should make this delegate to our API maybe @dikaiosune? In the same way we do it for navigator.geolocation

PushNotificationIOS won't work inside Expo, as it has to handle its own push notifs

Does it work at all, CRNA or otherwise? 😆
In all seriousness, this should probably be removed from core.

Geolocation requires a polyfill that will most likely ship with next week's release, but that won't have any manifest changes necessary

Yup! As discussed in Slack, we may want to have some way to generically say/flag "if you use CRNA this works without any additional work, if not, here's a bunch of stuff you need to do".

Linking involves changing Android manifests and other native-side things

Same sort of thing as geolocation would be useful here.

anp · 2017-04-05T01:00:43Z

PermissionsAndroid:

Talking to @jesseruder it sounds likely that a true polyfill here will be brittle, maybe? The way that using the API fails inside Expo isn't great, so we could at a minimum override it to throw a nicer exception + add a docs banner here that links to Expo's permissions docs?

PushNotificationIOS:

I don't contest its removal, but since it's there right now we need to have some answer for its docs :P.

Geolocation:

I agree that we need something to call out do-this-only-if-building-native steps. @hramos what do you think about making some sections collapsable vs. using a banner vs. some other strategy to differentiate?

Linking:

I think we probably need to document the Expo Linking strategy first, right?

peterp · 2017-04-05T09:50:08Z

I personally don't think that this should be the suggested route as Snack and Create React Native App appear to fill an evaluation, learning, or tutorial phase rather than a setting up your own development environment phase.

Perhaps the "Getting Started" is the correct place, but we could use an explicit document for setting up your own development environment?

anp · 2017-04-06T19:16:34Z

@peterp I'll flesh out the motivation of the PR a little more.

I think that React's Installation guide offers a nice example for React Native to follow. There are 3 options there:

CodePen (try it in your browser)
Create React App (boilerplate generator which often just fills the evaluation, learning, or tutorial role)
Full-blown make-your-own-build setup (lots of people don't need this, and if this were the only option it would be a big blocker for new user adoption)

Today, the React Native docs only show react-native-cli, which is kind of a hybrid of 2 & 3 from that list. It does have a template project it creates for you, but you also need to setup a full-blown native mobile dev environment to be able to use it.

Create React Native App fits in more or less as number 2 on that list. You're right that it fills an evaluation, learning, or tutorial role today. However, I think it's extremely important for documentation to provide new users with ways to get familiar before they dive all the way in -- we know from experience reports of new users that a multi-GB Xcode or AS download/install is a huge barrier to trying out React Native, which means they may never get the chance to fall in love with it.

I agree that it could make sense to separate Getting Started from a "Native Builds" document, but I think there are challenges with that approach. For one thing, unless you use Expo's build service, it's difficult today to take CRNA all the way to production the same way you can with Create React App, and we wouldn't want to give new users the impression that they can't build real, deployable, production-grade mobile apps with RN. That's what we all presumably want new users to do! The inability to write your own native code also means that for many users CRNA won't be the only way they ever use React Native, even if they don't publish an app to the stores. As a result of these and other tradeoffs, I think it's important to maintain a front-and-center presence for the Native Build section in addition to showing CRNA first.

The way I'm proposing to structure this is an attempt to honor both goals: acquire new users without hiding the full power of RN. That said, this may not be the correct path forward.

@hramos what do you think?

Looking through the current community Parse tutorials I found several candidates for a replacement: http://docs.parseplatform.org/parse-server/guide/#push-notifications-quick-start https://github.com/parse-community/PushTutorial/blob/master/iOS/README.md#1-creating-the-ssl-certificate The first (as of 4/6/17) is a broken anchor, and the second, which comes from text that I assume the first anchor is meant to point to, is a 404.

This is partially supported in CRNA right now, but it will be a month or two before we can figure out full support for all of the methods.

hramos · 2017-04-06T23:46:11Z

I believe CRNA is a great way for someone completely new to React Native to get started building their first app. With CRNA there is no need to set up a full development environment for both iOS and Android, and as the person maintaining the Getting Started guide for the past year or so -- ooh boy, are the steps to get a clean, reasonable Android dev environment ever changing and confusing even to someone experienced. I'm very happy to see CRNA presented as a starter.

We should of course highlight in the same guide that there is an option that entails setting up the entire development environment. For people experienced with building native apps who already have most or all of the environment set up, the steps for them to follow may very well be minimal and yet a more interesting route to take than CRNA (run your apps directly in the simulator/AVD/devices you already have, no need to install Expo or worry about reachability in your network!). Nevertheless, this should be the "Expert" portion of the guide, presented after CRNA.

It's not *technically* accurate to say it only works in native built apps, since the CRNA entry point does in fact call this indirectly, but CRNA does handle it for you.

Because the native-relevant sections are spread out around the guide currently, it seems prudent to create a separate section for them so that only a single "native builds needed" banner is needed. This reduces visual clutter and progressively discloses information to the reader based on their skill level and the complexity of their app. Also adds a couple of notes to the ejected subsections that CRNA handles certain things for you already.

anp · 2017-04-07T00:32:04Z

So of the items I identified as needing work, the only outstanding question I have is how to handle the fact that CRNA will lag stable RN releases by a week or so. This has already come up as a potential source of confusion (c.f. expo/create-react-native-app#151), but I'm not sure whether there's a way to make this smooth. Presumably people who care about a particular RN version before CRNA catches up are already "advanced users" and will have ejected or be willing/able to do their own native builds.

I'm definitely open to suggestions as to whether it's something we could/should handle at all in the docs. @hramos, I think this is probably ready for review whenever you have time unless you have any insight about handling that version lag.

peterp · 2017-04-07T07:11:06Z

Thanks @dikaiosune, I appreciate you taking the time to ease my concerns, and I appreciate the way that you're attempting to decrease the barrier of entry for people interested in React Native.

hramos

I have some minor feedback but generally I'm good with merging this. I'd also like to hear your thoughts on React's updated installation guide, which now has separate tabs for each alternative (see https://facebook.github.io/react/docs/installation.html, these tabs were added after this PR was opened).

I like the way they open with a question: do you want to create a new React app, add React to an existing app, or just try out React?

I think this is something we can explore in another PR.

hramos · 2017-04-24T14:04:13Z

docs/GettingStarted.md

+
+[Create React Native App](https://github.com/react-community/create-react-native-app) is the easiest way to start building a new React Native application. It allows you to start a project without installing or configuring any native build tools.
+
+Assuming that you have Node installed, no Xcode or Android Studio installation is required:


The phrasing here seems a bit odd to me (but keep in mind, English is my second language). The way I read it, Xcode or Android Studio may be required if I don't have Node installed.
Maybe we can split into two sentences, and swap the order? Something like:

No Xcode or Android Studio installation is required. Assuming that you have Node installed, you can run the following commands to create a new React Native projected called "AwesomeProject":

I'm mirroring the instructions for Native Builds at the end here, "AwesomeProject" could be anything but ideally it would match the original RN init commands.

After this PR gets merged I'll probably take another pass at updating the Getting Started guide and subsequent pages, as I'd like to update the tutorial so that it builds on top of the CRNA started project similar to what we did at F8 this year.

hramos · 2017-04-24T14:04:59Z

docs/GettingStarted.md

+
+```
+npm install -g create-react-native-app
+create-react-native-app hello-world


Change this and the next line to AwesomeApp (or update the instructions for RN init to use "hello-world", too)

hramos · 2017-04-24T14:07:54Z

docs/GettingStarted.md

+
+This will start a development server for you, and print a QR code in your terminal.
+
+Install the [Expo](https://expo.io) client app on your iOS or Android phone, make sure your phone is on the same network as your computer, and scan the QR code in your terminal to open your project. The QR scanner is available under the "Projects" tab of the app. Create React Native App also has a [user guide](https://github.com/react-community/create-react-native-app/blob/master/react-native-scripts/template/README.md) you can reference if you have questions specific to the tool.


I think we can leave out "The QR scanner is available under the Projects tab of the app". When I launch the Expo app, the Projects tab is visible by default and I can see a "Scan QR Code" callout at the top so it seems people can figure this out.

I don't feel too strongly about this though, if for example you've found that Expo users tend to be confused by this bit then we can leave this in.

hramos · 2017-04-24T14:10:32Z

docs/GettingStarted.md

+
+Once you've created your project and opened it in the Expo client app, you can proceed to the [Tutorial](docs/tutorial.html).
+
+### Caveats


Ideally we'd have a standalone CRNA doc that covers any caveats, as well as the ejection process. We can tackle that in a different PR though, I'm OK with this section here for now.

hramos · 2017-04-24T14:11:12Z

docs/GettingStarted.md

+
+### Caveats
+
+Because you don't build any native code with Create React Native App, it's not possible to include custom native modules beyond the React Native APIs and components that are available in the Expo client app.


Looks good to me, once we have a CRNA doc we can be more verbose there.

hramos · 2017-04-24T14:11:49Z

docs/GettingStarted.md

+
+<hr style="margin-top:25px"/>
+
+## Native Builds


I'm not sure about this section title yet but I don't have a better suggestion just yet shrug

Alternatives I see right off the bat:

Building with Xcode and Android Studio

Custom Build Environment

Building with Custom Native Code

Building Your Own Native Code

I've been thinking about this and have currently landed on these two terms to distinguish between the two types of React Native projects people might be working with:

Create-React-Native-App Projects

Projects with Native Code

The second one covers any project created using react-native init, or using CRNA but has since "ejected".

If we use these terms, then this section could be named "Building Projects with Native Code". Thoughts?

hramos · 2017-04-24T14:13:31Z

docs/GettingStarted.md

+
+## Native Builds
+
+Follow these instructions if you need your own native build configuration. For example, if you "ejected" from Create React Native app, or if you are integrating React Native into an existing application, you'll need this section.


Maybe explain that, if you "ejected" or are integrating into an existing app, you will need to setup all the dependencies covered in this section. The idea would be to make it clear RN init is not necessary (as you already have a project). To me it's obvious RN init is not needed, but it may not be clear to a new user if RN init does some additional, required setup.

That's a great point. What do you think about making the example commands something like this?

# skip this first command if you ejected from Create React Native App react-native init AwesomeProject cd AwesomeProject react-native run-ios

I think that's the most likely place for users to see it, but it might be better to have a more thorough explanation elsewhere? Doing both might be too much given the limited real estate, but I'm very open to suggestions here.

OK, I pushed up a commit that implements the example I previously commented, let me know if you think it's too clunky or should be moved to a central location?

hramos · 2017-04-24T14:15:23Z

Libraries/PushNotificationIOS/PushNotificationIOS.js

 * Handle push notifications for your app, including permission handling and
 * icon badge number.
 *
 * To get up and running, [configure your notifications with Apple](https://developer.apple.com/library/ios/documentation/IDEs/Conceptual/AppDistributionGuide/AddingCapabilities/AddingCapabilities.html#//apple_ref/doc/uid/TP40012582-CH26-SW6)
- * and your server-side system. To get an idea, [this is the Parse guide](https://parse.com/tutorials/ios-push-notifications).
+ * and your server-side system.


/me pours one out for Parse.

anp · 2017-04-24T18:51:38Z

Thanks for the review @hramos!

I agree that the React tabs are quite handsome, and I also agree it would be good to provide users better ways to self-select into the various paths here. I'm not sure what the options would be exactly, because in addition to React's motivations we also have "start a new app where I know that I need my own native code." I'll think about this more and we can chat about it when discussing the dedicated CRNA page?

facebook-github-bot · 2017-04-25T22:49:10Z

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2017-04-26T11:48:50Z

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

Summary: cc hramos Create React Native App was designed to reduce "time to hello world" to 5-10 minutes for React Native apps. This PR would make CRNA the first way to get started that new users encounter. Included also is some text to help advanced users navigate the question of whether to use CRNA or whether to go straight to `react-native init`. It also includes a new banner for the iOS and Android guides, since they do not apply to CRNA users. Changes are only to the website, screenshots below. This branch was created from the last CI-passing master commit this morning, dependencies were freshly installed and these screenshots are from a clean build. [The Getting Started page](https://www.dropbox.com/s/1s7f3wu3oxr6gpo/Screenshot%202017-04-04%2015.12.29.png?dl=0) [The "native builds only" banner](https://www.dropbox.com/s/nyv51xdiibdkn57/Screenshot%202017-04-04%2015.13.25.png?dl=0) [Pages which still apply to CRNApps have no banner](https://www.dropbox.com/s/qgl0h6uzynqkmy2/Screenshot%202017-04-04%2015.14.10.png?dl=0) <details> * [x] Decide how to handle native code & react-native-cli references outside of the `banner: ejected` guides * [x] [Debugging: Accessing Console Logs](https://facebook.github.io/react-native/docs/debugging.html#accessing-console-logs) isn't needed in CRNA (logs are forwarded alongside packager output) * [x] [Debugging: With Stetho](https://facebook.github.io/react-native/docs/debugging.html#debugging-with-stetho-http-facebook-github-io-stetho-on-android) requires native code * [x] [Debugging: Debugging Native Code](https://facebook.github.io/react-native/docs/debugging.html#debugging-native-code) is native-only * [x] [AppRegistry](https://facebook.github.io/react-native/docs/appregistry.html) only applies to ejected apps, since this is generated from code, I don't think we can set `banner: ejected`? * [x] [Linking](https://facebook.github.io/react-native/docs/linking.html) involves changing Android manifests and other native-side things * [x] [PermissionsAndroid](https://facebook.github.io/react-native/docs/permissionsandroid.html) may be flaky in the Expo client, I can't recall (cc jesseruder) * [x] [PushNotificationIOS](https://facebook.github.io/react-native/docs/pushnotificationios.html) won't work inside Expo, as it has to [handle its own push notifs](https://docs.expo.io/versions/v15.0.0/guides/push-notifications.html) * [x] [Geolocation](https://facebook.github.io/react-native/docs/geolocation.html) requires a polyfill that will most likely ship with next week's release, but that won't have any manifest changes necessary * [ ] Figure out a strategy to handle the fact that CRNA will lag stable RN releases by ~1 week * [x] Confirm linking out to CRNA docs is an OK strategy as opposed to moving ejecting, etc. docs in-tree * [ ] Answer questions (I'll add some review comments to call out a few things) </details> Closes facebook#13303 Differential Revision: D4950661 Pulled By: hramos fbshipit-source-id: 3dd43828f38ca6ede3f2b0683608c56420dc6525

Summary: This sync includes the following changes: - **[ade5e6928](facebook/react@ade5e6928)**: Manually update schedule dep in react-native-renderer (#13609) //<Brian Vaughn>// - **[f260b14a8](facebook/react@f260b14a8)**: Fix host bailout for the persistent mode (#13611) //<Dan Abramov>// - **[4a40d7624](facebook/react@4a40d7624)**: Fix a regression related to isReactComponent prototype check (#13608) //<Dan Abramov>// - **[03ab1efeb](facebook/react@03ab1efeb)**: Improve DX when combining react-dom/profiling and schedule/tracking (#13605) //<Brian Vaughn>// - **[144328fe8](facebook/react@144328fe8)**: Enable no-use-before-define rule (#13606) //<Dan Abramov>// - **[8a8d973d3](facebook/react@8a8d973d3)**: Use clearer wording //<Dan>// - **[7d1169b2d](facebook/react@7d1169b2d)**: Remove injectComponentTree from unstable-native-dependencies, add EventPluginHub (#13598) //<Brandon Dail>// - **[8d1038fc6](facebook/react@8d1038fc6)**: Break up ReactDOMServerIntegrationForm-test (#13600) //<Nathan Hunzaker>// - **[b87aabdfe](facebook/react@b87aabdfe)**: Drop the year from Facebook copyright headers and the LICENSE file. (#13593) //<Héctor Ramos>// - **[e417e0bf7](facebook/react@e417e0bf7)**: Update ReactNativeViewConfigRegistry Flow Types (#13579) //<Timothy Yung>// - **[71c0e05ba](facebook/react@71c0e05ba)**: Update bundle sizes for 16.5.0 release //<Brian Vaughn>// - **[6255cc394](facebook/react@6255cc394)**: Updating package versions for release 16.5.0 //<Brian Vaughn>// - **[28cb37978](facebook/react@28cb37978)**: Added a test for Profiler onRender that throws (#13575) //<Brian Vaughn>// - **[8963118b3](facebook/react@8963118b3)**: Update react-dom README //<Dan Abramov>// - **[b47a28cb9](facebook/react@b47a28cb9)**: Tweak react-dom README //<Dan Abramov>// - **[f765f0225](facebook/react@f765f0225)**: When a root expires, flush all expired work in a single batch (#13503) //<Andrew Clark>// - **[550dd1d2e](facebook/react@550dd1d2e)**: Call Profiler onRender after mutations (#13572) //<Brian Vaughn>// - **[34348a45b](facebook/react@34348a45b)**: Add enableSuspenseServerRenderer feature flag (#13573) //<Alex Taylor>// - **[4e744be6e](facebook/react@4e744be6e)**: Added react-dom/profiling entry point to NPM package (#13570) //<Brian Vaughn>// - **[bb627228e](facebook/react@bb627228e)**: test: add test for fragement props (#13565) //<laoxiong>// - **[9a110ebd8](facebook/react@9a110ebd8)**: Cleaned up 'schedule' API wrt interactions and subscriber ref: (#13561) //<Brian Vaughn>// - **[fb88fd9d8](facebook/react@fb88fd9d8)**: Fixed schedule/tracking require for www sync script (#13556) //<Brian Vaughn>// - **[955393cab](facebook/react@955393cab)**: refactor: remove emove type judgment when defining warning props (#13553) //<laoxiong>// - **[ff9399602](facebook/react@ff9399602)**: Fix import of ReactDOM in server env //<Dan Abramov>// - **[281bd64c0](facebook/react@281bd64c0)**: Fix test file name //<Dan Abramov>// - **[d6b59e3d2](facebook/react@d6b59e3d2)**: Check document.documentMode once //<Dan Abramov>// - **[52633c84e](facebook/react@52633c84e)**: Try/finally //<Dan Abramov>// - **[2d4705e75](facebook/react@2d4705e75)**: Make IE 11 not complain about non-crucial style attribute hydration mismatch (#13534) //<Michał Gołębiowski-Owczarek>// - **[25d48a728](facebook/react@25d48a728)**: Add gridArea to unitless CSS properties (#13550) //<Michał Gołębiowski-Owczarek>// - **[877f8bc6b](facebook/react@877f8bc6b)**: Renamed schedule UMD forwarding methods to stay in-sync with SECRET_INTERNALS change (#13549) //<Brian Vaughn>// - **[0a96f9057](facebook/react@0a96f9057)**: Revert "Extract common logic" (#13547) //<Dan Abramov>// - **[17a57adde](facebook/react@17a57adde)**: Fix test //<Dan Abramov>// - **[605da8b42](facebook/react@605da8b42)**: Extract common logic (#13535) //<Heaven>// - **[69f9f4127](facebook/react@69f9f4127)**: Document event bubble order (#13546) //<Philipp>// - **[c1ba7b8cf](facebook/react@c1ba7b8cf)**: Remove www scheduler fork (#13545) //<Dan Abramov>// - **[b473d5f86](facebook/react@b473d5f86)**: Secret exports: Scheduler => Schedule (#13544) //<Dan Abramov>// - **[6312efc34](facebook/react@6312efc34)**: Tweak README and description //<Dan Abramov>// - **[b92f947af](facebook/react@b92f947af)**: Rename "react-scheduler" package to "schedule" (#13543) //<Brian Vaughn>// - **[3c1dcd349](facebook/react@3c1dcd349)**: Expose less internals for TestUtils (#13539) //<Dan Abramov>// - **[0b74e95d7](facebook/react@0b74e95d7)**: Ignore noscript content on the client (#13537) //<Fredrik Höglund>// - **[8a1e3962a](facebook/react@8a1e3962a)**: Remove negative lookbehind from Rollup plugin that broke Node <= v8.9 (#13538) //<Brian Vaughn>// - **[9604d26ae](facebook/react@9604d26ae)**: Rename ReactDOMFiber* to ReactDOM* (#13540) //<Dan Abramov>// - **[28b928902](facebook/react@28b928902)**: Tidied up scheduling UMD API forwarding test (#13533) //<Brian Vaughn>// - **[bf8aa6092](facebook/react@bf8aa6092)**: Added Jest test to verify UMD API-forwarding for scheduling package (#13532) //<Brian Vaughn>// - **[0040efc8d](facebook/react@0040efc8d)**: Fix a typo (#13531) //<Heaven>// - **[46950a3df](facebook/react@46950a3df)**: Interaction tracking follow up (#13509) //<Brian Vaughn>// - **[0452c9bba](facebook/react@0452c9bba)**: Add a regression test for #4618 //<Dan Abramov>// - **[c21bab694](facebook/react@c21bab694)**: Add SSR regression test for #6119 //<Dan Abramov>// - **[0d3fc9de1](facebook/react@0d3fc9de1)**: Add regression test for #6119 //<Dan Abramov>// - **[0f050ad7c](facebook/react@0f050ad7c)**: Make regression test better //<Dan Abramov>// - **[f94342323](facebook/react@f94342323)**: Add a more precise regression test for #6219 //<Dan Abramov>// - **[a3e4d0008](facebook/react@a3e4d0008)**: Fixed typo (#13519) //<Ivan>// - **[b3d8c5376](facebook/react@b3d8c5376)**: [RN] Remove isMounted() false positive warning (#13511) //<Dan Abramov>// - **[d2123d656](facebook/react@d2123d656)**: Sync React Native Flow Changes (#13513) //<Timothy Yung>// - **[1c0ba70b4](facebook/react@1c0ba70b4)**: Fix test to use AsyncMode //<Dan>// - **[6e4f7c788](facebook/react@6e4f7c788)**: Profiler integration with interaction-tracking package (#13253) //<Brian Vaughn>// - **[2967ebdbe](facebook/react@2967ebdbe)**: Remove buggy unstable_deferredUpdates() (#13488) //<Dan Abramov>// - **[1664b08f0](facebook/react@1664b08f0)**: added flow types to setInnerHTML (#13495) //<Bryan M>// - **[672e859d3](facebook/react@672e859d3)**: Add warning to prevent setting this.state to this.props referentially (#11658) //<Veekas Shrivastava>// - **[29287f088](facebook/react@29287f088)**: Rename lowestPendingInteractiveExpirationTime (#13484) //<Heaven>// - **[d400d6d5e](facebook/react@d400d6d5e)**: Replace magic number 1 with ELEMENT_NODE (#13479) //<Heaven>// - **[340bfd939](facebook/react@340bfd939)**: Rename ReactTypeOfWork to ReactWorkTags, ReactTypeOfSideEffect to ReactSideEffectTags (#13476) //<Sophie Alpert>// - **[5cefd9b1e](facebook/react@5cefd9b1e)**: Stringify <option> children (#13465) //<Dan Abramov>// - **[3661616c2](facebook/react@3661616c2)**: Improve test harness of submit events (#13463) //<Philipp Spieß>// - **[a1be17140](facebook/react@a1be17140)**: Revert "Rely on bubbling for submit and reset events (#13358)" (#13462) //<Dan Abramov>// - **[90c92c700](facebook/react@90c92c700)**: Fix warning message //<Dan Abramov>// - **[5cb0f2bf5](facebook/react@5cb0f2bf5)**: Change www error shim API (#13454) //<Dan Abramov>// - **[e106b8c44](facebook/react@e106b8c44)**: Warn about unsafe toWarnDev() nesting in tests (#12457) //<Brian Vaughn>// - **[026aa9c97](facebook/react@026aa9c97)**: Bumped version to 16.4.3-alpha.0 (#13448) //<Brian Vaughn>// - **[d670bdc6b](facebook/react@d670bdc6b)**: Warn about ReactDOM.createPortal usage within ReactTestRenderer (#12895) //<Brian Vaughn>// - **[bf1abf478](facebook/react@bf1abf478)**: Fix React.lazy(forwardRef) (#13446) //<Dan Abramov>// - **[e8571c798](facebook/react@e8571c798)**: Tweak ReactTypeOfWork order (#13444) //<Dan Abramov>// - **[973496b40](facebook/react@973496b40)**: Fix component name for React.lazy (#13443) //<Dan Abramov>// - **[0beb2ee76](facebook/react@0beb2ee76)**: Fix incorrect legacy context for factory components (#13441) //<Dan Abramov>// - **[004cb21bb](facebook/react@004cb21bb)**: Short circuit the logic for exporting a module (#13392) //<Joseph>// - **[f7a538c91](facebook/react@f7a538c91)**: Remove getTextContentAccessor (#13434) //<Brandon Dail>// - **[d1c42d2f1](facebook/react@d1c42d2f1)**: Remove addEventListener check in isEventSupported (#13435) //<Brandon Dail>// - **[a869f992a](facebook/react@a869f992a)**: Remove helper object from FallbackCompositionState (#13430) //<Brandon Dail>// - **[0cd8d470d](facebook/react@0cd8d470d)**: Do not toLowerCase lists of lowercase words (#13428) //<Nathan Hunzaker>// - **[b3a4cfea5](facebook/react@b3a4cfea5)**: Trap click events for portal root (#11927) //<Brandon Dail>// - **[0da5102cf](facebook/react@0da5102cf)**: Add interaction-tracking/subscriptions (#13426) //<Brian Vaughn>// - **[4b32f525e](facebook/react@4b32f525e)**: Refactor away some namespace imports (#13427) //<Dan Abramov>// - **[d2f5c3fbc](facebook/react@d2f5c3fbc)**: Don't diff memoized host components in completion phase (#13423) //<Dan Abramov>// - **[5e0f073d5](facebook/react@5e0f073d5)**: interaction-tracking package (#13234) //<Brian Vaughn>// - **[d14e443d6](facebook/react@d14e443d6)**: Resume onSelect tracking after dragend (#13422) //<Dan Abramov>// - **[d5edc1f51](facebook/react@d5edc1f51)**: Remove unused ReactCall & ReactReturn types (#13419) //<Esteban>// - **[4fa20b53b](facebook/react@4fa20b53b)**: Don't pass instanceHandle to clones (#13125) //<Sebastian Markbåge>// - **[fe959eea7](facebook/react@fe959eea7)**: React.lazy (#13398) //<Andrew Clark>// - **[2b3082800](facebook/react@2b3082800)**: Fix wrong Flow return type //<Andrew Clark>// - **[5031ebf6b](facebook/react@5031ebf6b)**: Accept promise as element type (#13397) //<Andrew Clark>// - **[77b7a660b](facebook/react@77b7a660b)**: fix: do not reconcile children that are iterable functions (#13416) //<Rauno Freiberg>// - **[cb7745c6c](facebook/react@cb7745c6c)**: remove unused state initialValue from ReactDOMFiberSelect (#13412) //<Kartik Lad>// - **[9832a1b6d](facebook/react@9832a1b6d)**: Avoid setting empty value on reset & submit inputs (#12780) //<Ellis Clayton>// - **[8862172fa](facebook/react@8862172fa)**: Provide a better error message (#12421) //<Aaron Brager>// - **[581682917](facebook/react@581682917)**: De-duplicate commitUpdateQueue effect commit (#13403) //<Ruud Burger>// - **[1bc975d07](facebook/react@1bc975d07)**: Don't stop context traversal at matching consumers (#13391) //<Andrew Clark>// - **[83e446e1d](facebook/react@83e446e1d)**: Refactor ReactErrorUtils (#13406) //<Dan Abramov>// - **[13fa96a54](facebook/react@13fa96a54)**: Improve bad ref invariant (#13408) //<Dan Abramov>// - **[b2adcfba3](facebook/react@b2adcfba3)**: Don't suppress jsdom error reporting in our tests (#13401) //<Dan Abramov>// - **[69e2a0d73](facebook/react@69e2a0d73)**: Ability to access window.event in development (#11687) (#11696) //<Conrad Irwin>// - **[ade4dd3f6](facebook/react@ade4dd3f6)**: Fix typo in a comment (#13373) //<davidblnc>// - **[2c59076d2](facebook/react@2c59076d2)**: Warn when "false" or "true" is the value of a boolean DOM prop (#13372) //<Moti Zilberman>// - **[de5102c4c](facebook/react@de5102c4c)**: Ignore symbols and functions in select tag (#13389) //<Rauno Freiberg>// - **[d04d03e47](facebook/react@d04d03e47)**: Fix passing symbols and functions to textarea (#13362) //<Rauno Freiberg>// - **[5550ed4a8](facebook/react@5550ed4a8)**: Ensure arguments are coerced to strings in warnings (#13385) //<Nathan Hunzaker>// - **[3938ccc88](facebook/react@3938ccc88)**: Allow the user to opt out of seeing "The above error..." addendum (#13384) //<Dan Abramov>// - **[47e217a77](facebook/react@47e217a77)**: Provide component reference in ReactDOMFiberTextarea warnings (#13361) //<Rauno Freiberg>// - **[a0190f828](facebook/react@a0190f828)**: Rename SafeValue to ToStringValue (#13376) //<Philipp Spieß>// - **[33602d435](facebook/react@33602d435)**: Improve soundness of ReactDOMFiberInput typings (#13367) //<Philipp Spieß>// - **[ae855cec2](facebook/react@ae855cec2)**: Support tangentialPressure and twist fields of pointer events (#13374) //<Moti Zilberman>// - **[725e499cf](facebook/react@725e499cf)**: Rely on bubbling for submit and reset events (#13358) //<Philipp Spieß>// - **[e07a3cd28](facebook/react@e07a3cd28)**: fix typo on inline comment (#13364) //<Alex Rohleder>// - **[e0204084a](facebook/react@e0204084a)**: Fix typos detected by github.com/client9/misspell (#13349) //<Kazuhiro Sera>// - **[be4533af7](facebook/react@be4533af7)**: Fix hydration of non-string dangerousSetInnerHTML.__html (#13353) //<Dan Abramov>// - **[0072b5998](facebook/react@0072b5998)**: Improve scry() error message for bad first argument (#13351) //<Dan Abramov>// - **[d59b993a7](facebook/react@d59b993a7)**: Make nicer stacks DEV-only //<Dan>// - **[54d86eb82](facebook/react@54d86eb82)**: Improve display of filenames in component stack (#12059) //<Billy Janitsch>// - **[067cc24f5](facebook/react@067cc24f5)**: Profiler actualDuration bugfix (#13313) //<Brian Vaughn>// - **[3cfab14b9](facebook/react@3cfab14b9)**: Treat focusable as enumerated boolean SVG attribute (#13339) //<Dan Abramov>// - **[3b3b7fcbb](facebook/react@3b3b7fcbb)**: Don't search beyond Sync roots for highest priority work (#13335) //<Dan Abramov>// - **[08e32263f](facebook/react@08e32263f)**: Fix Prettier "No parser" warning while building (#13323) //<Bartosz Kaszubowski>// - **[ac7238856](facebook/react@ac7238856)**: Add support for auxclick event (#11571) //<Jason Quense>// - **[75491a8f4](facebook/react@75491a8f4)**: Add a regression test for #12200 (#12242) //<Gareth Small>// - **[2d0356a52](facebook/react@2d0356a52)**: Make sure that `select` has `multiple` attribute set to appropriate state before appending options (#13270) //<Dmytro Zasyadko>// - **[b179bae0a](facebook/react@b179bae0a)**: Enhance get derived state from props state warning - #12670 (#13317) //<Felix Wu>// - **[15a8f0318](facebook/react@15a8f0318)**: Fix ambiguity in doc comment for isValidElement (#12826) //<Alexey>// - **[5cff21207](facebook/react@5cff21207)**: add flowtype to function signature (#13285) //<ryota-murakami>// - **[b565f4953](facebook/react@b565f4953)**: Minimally support iframes (nested browsing contexts) in selection event handling (#12037) //<Andrew Patton>// - **[1609cf343](facebook/react@1609cf343)**: Warn about rendering Generators (#13312) //<Dan Abramov>// - **[46d5afc54](facebook/react@46d5afc54)**: Replace console.error() with a throw in setTimeout() as last resort exception logging (#13310) //<Dan Abramov>// - **[b3b80a483](facebook/react@b3b80a483)**: Inject react-art renderer into react-devtools (#13173) //<Yunchan Cho>// - **[5e8beec84](facebook/react@5e8beec84)**: Add a regression test for #11602 //<Dan Abramov>// - **[470377bbd](facebook/react@470377bbd)**: Remove extraneous condition //<Dan Abramov>// - **[6db080154](facebook/react@6db080154)**: Remove irrelevant suggestion of a legacy method from a warning (#13169) //<Ideveloper>// - **[f60a7f722](facebook/react@f60a7f722)**: Fix SSR crash on a hasOwnProperty attribute (#13303) //<Dan Abramov>// - **[ff41519ec](facebook/react@ff41519ec)**: Sanitize unknown attribute names for SSR (#13302) //<Dan Abramov>// - **[c44c2a216](facebook/react@c44c2a216)**: More helpful message when passing an element to createElement() (#13131) //<Dylan Cutler>// - **[28cd494bd](facebook/react@28cd494bd)**: Refactor validateDOMNesting a bit (#13300) //<Dan Abramov>// - **[b381f4141](facebook/react@b381f4141)**: Allow Electrons <webview> tag (#13301) //<Philipp Spieß>// - **[0182a7463](facebook/react@0182a7463)**: Fix a crash when using dynamic children in <option> tag (#13261) //<Konstantin Yakushin>// - **[2a2ef7e0f](facebook/react@2a2ef7e0f)**: Remove unnecessary branching from updateContextProvider (#13282) //<Andrew Clark>// - **[840cb1a26](facebook/react@840cb1a26)**: Add an invariant to createRoot() to validate containers (#13279) //<Dan Abramov>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions bc1ea9c...ade5e69 Reviewed By: bvaughn Differential Revision: D9561644 fbshipit-source-id: 3be120d7450f310af458897d54993a6c086cff2f

Summary: This sync includes the following changes: - **[ade5e6928](facebook/react@ade5e6928)**: Manually update schedule dep in react-native-renderer (facebook#13609) //<Brian Vaughn>// - **[f260b14a8](facebook/react@f260b14a8)**: Fix host bailout for the persistent mode (facebook#13611) //<Dan Abramov>// - **[4a40d7624](facebook/react@4a40d7624)**: Fix a regression related to isReactComponent prototype check (facebook#13608) //<Dan Abramov>// - **[03ab1efeb](facebook/react@03ab1efeb)**: Improve DX when combining react-dom/profiling and schedule/tracking (facebook#13605) //<Brian Vaughn>// - **[144328fe8](facebook/react@144328fe8)**: Enable no-use-before-define rule (facebook#13606) //<Dan Abramov>// - **[8a8d973d3](facebook/react@8a8d973d3)**: Use clearer wording //<Dan>// - **[7d1169b2d](facebook/react@7d1169b2d)**: Remove injectComponentTree from unstable-native-dependencies, add EventPluginHub (facebook#13598) //<Brandon Dail>// - **[8d1038fc6](facebook/react@8d1038fc6)**: Break up ReactDOMServerIntegrationForm-test (facebook#13600) //<Nathan Hunzaker>// - **[b87aabdfe](facebook/react@b87aabdfe)**: Drop the year from Facebook copyright headers and the LICENSE file. (facebook#13593) //<Héctor Ramos>// - **[e417e0bf7](facebook/react@e417e0bf7)**: Update ReactNativeViewConfigRegistry Flow Types (facebook#13579) //<Timothy Yung>// - **[71c0e05ba](facebook/react@71c0e05ba)**: Update bundle sizes for 16.5.0 release //<Brian Vaughn>// - **[6255cc394](facebook/react@6255cc394)**: Updating package versions for release 16.5.0 //<Brian Vaughn>// - **[28cb37978](facebook/react@28cb37978)**: Added a test for Profiler onRender that throws (facebook#13575) //<Brian Vaughn>// - **[8963118b3](facebook/react@8963118b3)**: Update react-dom README //<Dan Abramov>// - **[b47a28cb9](facebook/react@b47a28cb9)**: Tweak react-dom README //<Dan Abramov>// - **[f765f0225](facebook/react@f765f0225)**: When a root expires, flush all expired work in a single batch (facebook#13503) //<Andrew Clark>// - **[550dd1d2e](facebook/react@550dd1d2e)**: Call Profiler onRender after mutations (facebook#13572) //<Brian Vaughn>// - **[34348a45b](facebook/react@34348a45b)**: Add enableSuspenseServerRenderer feature flag (facebook#13573) //<Alex Taylor>// - **[4e744be6e](facebook/react@4e744be6e)**: Added react-dom/profiling entry point to NPM package (facebook#13570) //<Brian Vaughn>// - **[bb627228e](facebook/react@bb627228e)**: test: add test for fragement props (facebook#13565) //<laoxiong>// - **[9a110ebd8](facebook/react@9a110ebd8)**: Cleaned up 'schedule' API wrt interactions and subscriber ref: (facebook#13561) //<Brian Vaughn>// - **[fb88fd9d8](facebook/react@fb88fd9d8)**: Fixed schedule/tracking require for www sync script (facebook#13556) //<Brian Vaughn>// - **[955393cab](facebook/react@955393cab)**: refactor: remove emove type judgment when defining warning props (facebook#13553) //<laoxiong>// - **[ff9399602](facebook/react@ff9399602)**: Fix import of ReactDOM in server env //<Dan Abramov>// - **[281bd64c0](facebook/react@281bd64c0)**: Fix test file name //<Dan Abramov>// - **[d6b59e3d2](facebook/react@d6b59e3d2)**: Check document.documentMode once //<Dan Abramov>// - **[52633c84e](facebook/react@52633c84e)**: Try/finally //<Dan Abramov>// - **[2d4705e75](facebook/react@2d4705e75)**: Make IE 11 not complain about non-crucial style attribute hydration mismatch (facebook#13534) //<Michał Gołębiowski-Owczarek>// - **[25d48a728](facebook/react@25d48a728)**: Add gridArea to unitless CSS properties (facebook#13550) //<Michał Gołębiowski-Owczarek>// - **[877f8bc6b](facebook/react@877f8bc6b)**: Renamed schedule UMD forwarding methods to stay in-sync with SECRET_INTERNALS change (facebook#13549) //<Brian Vaughn>// - **[0a96f9057](facebook/react@0a96f9057)**: Revert "Extract common logic" (facebook#13547) //<Dan Abramov>// - **[17a57adde](facebook/react@17a57adde)**: Fix test //<Dan Abramov>// - **[605da8b42](facebook/react@605da8b42)**: Extract common logic (facebook#13535) //<Heaven>// - **[69f9f4127](facebook/react@69f9f4127)**: Document event bubble order (facebook#13546) //<Philipp>// - **[c1ba7b8cf](facebook/react@c1ba7b8cf)**: Remove www scheduler fork (facebook#13545) //<Dan Abramov>// - **[b473d5f86](facebook/react@b473d5f86)**: Secret exports: Scheduler => Schedule (facebook#13544) //<Dan Abramov>// - **[6312efc34](facebook/react@6312efc34)**: Tweak README and description //<Dan Abramov>// - **[b92f947af](facebook/react@b92f947af)**: Rename "react-scheduler" package to "schedule" (facebook#13543) //<Brian Vaughn>// - **[3c1dcd349](facebook/react@3c1dcd349)**: Expose less internals for TestUtils (facebook#13539) //<Dan Abramov>// - **[0b74e95d7](facebook/react@0b74e95d7)**: Ignore noscript content on the client (facebook#13537) //<Fredrik Höglund>// - **[8a1e3962a](facebook/react@8a1e3962a)**: Remove negative lookbehind from Rollup plugin that broke Node <= v8.9 (facebook#13538) //<Brian Vaughn>// - **[9604d26ae](facebook/react@9604d26ae)**: Rename ReactDOMFiber* to ReactDOM* (facebook#13540) //<Dan Abramov>// - **[28b928902](facebook/react@28b928902)**: Tidied up scheduling UMD API forwarding test (facebook#13533) //<Brian Vaughn>// - **[bf8aa6092](facebook/react@bf8aa6092)**: Added Jest test to verify UMD API-forwarding for scheduling package (facebook#13532) //<Brian Vaughn>// - **[0040efc8d](facebook/react@0040efc8d)**: Fix a typo (facebook#13531) //<Heaven>// - **[46950a3df](facebook/react@46950a3df)**: Interaction tracking follow up (facebook#13509) //<Brian Vaughn>// - **[0452c9bba](facebook/react@0452c9bba)**: Add a regression test for facebook#4618 //<Dan Abramov>// - **[c21bab694](facebook/react@c21bab694)**: Add SSR regression test for facebook#6119 //<Dan Abramov>// - **[0d3fc9de1](facebook/react@0d3fc9de1)**: Add regression test for facebook#6119 //<Dan Abramov>// - **[0f050ad7c](facebook/react@0f050ad7c)**: Make regression test better //<Dan Abramov>// - **[f94342323](facebook/react@f94342323)**: Add a more precise regression test for facebook#6219 //<Dan Abramov>// - **[a3e4d0008](facebook/react@a3e4d0008)**: Fixed typo (facebook#13519) //<Ivan>// - **[b3d8c5376](facebook/react@b3d8c5376)**: [RN] Remove isMounted() false positive warning (facebook#13511) //<Dan Abramov>// - **[d2123d656](facebook/react@d2123d656)**: Sync React Native Flow Changes (facebook#13513) //<Timothy Yung>// - **[1c0ba70b4](facebook/react@1c0ba70b4)**: Fix test to use AsyncMode //<Dan>// - **[6e4f7c788](facebook/react@6e4f7c788)**: Profiler integration with interaction-tracking package (facebook#13253) //<Brian Vaughn>// - **[2967ebdbe](facebook/react@2967ebdbe)**: Remove buggy unstable_deferredUpdates() (facebook#13488) //<Dan Abramov>// - **[1664b08f0](facebook/react@1664b08f0)**: added flow types to setInnerHTML (facebook#13495) //<Bryan M>// - **[672e859d3](facebook/react@672e859d3)**: Add warning to prevent setting this.state to this.props referentially (facebook#11658) //<Veekas Shrivastava>// - **[29287f088](facebook/react@29287f088)**: Rename lowestPendingInteractiveExpirationTime (facebook#13484) //<Heaven>// - **[d400d6d5e](facebook/react@d400d6d5e)**: Replace magic number 1 with ELEMENT_NODE (facebook#13479) //<Heaven>// - **[340bfd939](facebook/react@340bfd939)**: Rename ReactTypeOfWork to ReactWorkTags, ReactTypeOfSideEffect to ReactSideEffectTags (facebook#13476) //<Sophie Alpert>// - **[5cefd9b1e](facebook/react@5cefd9b1e)**: Stringify <option> children (facebook#13465) //<Dan Abramov>// - **[3661616c2](facebook/react@3661616c2)**: Improve test harness of submit events (facebook#13463) //<Philipp Spieß>// - **[a1be17140](facebook/react@a1be17140)**: Revert "Rely on bubbling for submit and reset events (facebook#13358)" (facebook#13462) //<Dan Abramov>// - **[90c92c700](facebook/react@90c92c700)**: Fix warning message //<Dan Abramov>// - **[5cb0f2bf5](facebook/react@5cb0f2bf5)**: Change www error shim API (facebook#13454) //<Dan Abramov>// - **[e106b8c44](facebook/react@e106b8c44)**: Warn about unsafe toWarnDev() nesting in tests (facebook#12457) //<Brian Vaughn>// - **[026aa9c97](facebook/react@026aa9c97)**: Bumped version to 16.4.3-alpha.0 (facebook#13448) //<Brian Vaughn>// - **[d670bdc6b](facebook/react@d670bdc6b)**: Warn about ReactDOM.createPortal usage within ReactTestRenderer (facebook#12895) //<Brian Vaughn>// - **[bf1abf478](facebook/react@bf1abf478)**: Fix React.lazy(forwardRef) (facebook#13446) //<Dan Abramov>// - **[e8571c798](facebook/react@e8571c798)**: Tweak ReactTypeOfWork order (facebook#13444) //<Dan Abramov>// - **[973496b40](facebook/react@973496b40)**: Fix component name for React.lazy (facebook#13443) //<Dan Abramov>// - **[0beb2ee76](facebook/react@0beb2ee76)**: Fix incorrect legacy context for factory components (facebook#13441) //<Dan Abramov>// - **[004cb21bb](facebook/react@004cb21bb)**: Short circuit the logic for exporting a module (facebook#13392) //<Joseph>// - **[f7a538c91](facebook/react@f7a538c91)**: Remove getTextContentAccessor (facebook#13434) //<Brandon Dail>// - **[d1c42d2f1](facebook/react@d1c42d2f1)**: Remove addEventListener check in isEventSupported (facebook#13435) //<Brandon Dail>// - **[a869f992a](facebook/react@a869f992a)**: Remove helper object from FallbackCompositionState (facebook#13430) //<Brandon Dail>// - **[0cd8d470d](facebook/react@0cd8d470d)**: Do not toLowerCase lists of lowercase words (facebook#13428) //<Nathan Hunzaker>// - **[b3a4cfea5](facebook/react@b3a4cfea5)**: Trap click events for portal root (facebook#11927) //<Brandon Dail>// - **[0da5102cf](facebook/react@0da5102cf)**: Add interaction-tracking/subscriptions (facebook#13426) //<Brian Vaughn>// - **[4b32f525e](facebook/react@4b32f525e)**: Refactor away some namespace imports (facebook#13427) //<Dan Abramov>// - **[d2f5c3fbc](facebook/react@d2f5c3fbc)**: Don't diff memoized host components in completion phase (facebook#13423) //<Dan Abramov>// - **[5e0f073d5](facebook/react@5e0f073d5)**: interaction-tracking package (facebook#13234) //<Brian Vaughn>// - **[d14e443d6](facebook/react@d14e443d6)**: Resume onSelect tracking after dragend (facebook#13422) //<Dan Abramov>// - **[d5edc1f51](facebook/react@d5edc1f51)**: Remove unused ReactCall & ReactReturn types (facebook#13419) //<Esteban>// - **[4fa20b53b](facebook/react@4fa20b53b)**: Don't pass instanceHandle to clones (facebook#13125) //<Sebastian Markbåge>// - **[fe959eea7](facebook/react@fe959eea7)**: React.lazy (facebook#13398) //<Andrew Clark>// - **[2b3082800](facebook/react@2b3082800)**: Fix wrong Flow return type //<Andrew Clark>// - **[5031ebf6b](facebook/react@5031ebf6b)**: Accept promise as element type (facebook#13397) //<Andrew Clark>// - **[77b7a660b](facebook/react@77b7a660b)**: fix: do not reconcile children that are iterable functions (facebook#13416) //<Rauno Freiberg>// - **[cb7745c6c](facebook/react@cb7745c6c)**: remove unused state initialValue from ReactDOMFiberSelect (facebook#13412) //<Kartik Lad>// - **[9832a1b6d](facebook/react@9832a1b6d)**: Avoid setting empty value on reset & submit inputs (facebook#12780) //<Ellis Clayton>// - **[8862172fa](facebook/react@8862172fa)**: Provide a better error message (facebook#12421) //<Aaron Brager>// - **[581682917](facebook/react@581682917)**: De-duplicate commitUpdateQueue effect commit (facebook#13403) //<Ruud Burger>// - **[1bc975d07](facebook/react@1bc975d07)**: Don't stop context traversal at matching consumers (facebook#13391) //<Andrew Clark>// - **[83e446e1d](facebook/react@83e446e1d)**: Refactor ReactErrorUtils (facebook#13406) //<Dan Abramov>// - **[13fa96a54](facebook/react@13fa96a54)**: Improve bad ref invariant (facebook#13408) //<Dan Abramov>// - **[b2adcfba3](facebook/react@b2adcfba3)**: Don't suppress jsdom error reporting in our tests (facebook#13401) //<Dan Abramov>// - **[69e2a0d73](facebook/react@69e2a0d73)**: Ability to access window.event in development (facebook#11687) (facebook#11696) //<Conrad Irwin>// - **[ade4dd3f6](facebook/react@ade4dd3f6)**: Fix typo in a comment (facebook#13373) //<davidblnc>// - **[2c59076d2](facebook/react@2c59076d2)**: Warn when "false" or "true" is the value of a boolean DOM prop (facebook#13372) //<Moti Zilberman>// - **[de5102c4c](facebook/react@de5102c4c)**: Ignore symbols and functions in select tag (facebook#13389) //<Rauno Freiberg>// - **[d04d03e47](facebook/react@d04d03e47)**: Fix passing symbols and functions to textarea (facebook#13362) //<Rauno Freiberg>// - **[5550ed4a8](facebook/react@5550ed4a8)**: Ensure arguments are coerced to strings in warnings (facebook#13385) //<Nathan Hunzaker>// - **[3938ccc88](facebook/react@3938ccc88)**: Allow the user to opt out of seeing "The above error..." addendum (facebook#13384) //<Dan Abramov>// - **[47e217a77](facebook/react@47e217a77)**: Provide component reference in ReactDOMFiberTextarea warnings (facebook#13361) //<Rauno Freiberg>// - **[a0190f828](facebook/react@a0190f828)**: Rename SafeValue to ToStringValue (facebook#13376) //<Philipp Spieß>// - **[33602d435](facebook/react@33602d435)**: Improve soundness of ReactDOMFiberInput typings (facebook#13367) //<Philipp Spieß>// - **[ae855cec2](facebook/react@ae855cec2)**: Support tangentialPressure and twist fields of pointer events (facebook#13374) //<Moti Zilberman>// - **[725e499cf](facebook/react@725e499cf)**: Rely on bubbling for submit and reset events (facebook#13358) //<Philipp Spieß>// - **[e07a3cd28](facebook/react@e07a3cd28)**: fix typo on inline comment (facebook#13364) //<Alex Rohleder>// - **[e0204084a](facebook/react@e0204084a)**: Fix typos detected by github.com/client9/misspell (facebook#13349) //<Kazuhiro Sera>// - **[be4533af7](facebook/react@be4533af7)**: Fix hydration of non-string dangerousSetInnerHTML.__html (facebook#13353) //<Dan Abramov>// - **[0072b5998](facebook/react@0072b5998)**: Improve scry() error message for bad first argument (facebook#13351) //<Dan Abramov>// - **[d59b993a7](facebook/react@d59b993a7)**: Make nicer stacks DEV-only //<Dan>// - **[54d86eb82](facebook/react@54d86eb82)**: Improve display of filenames in component stack (facebook#12059) //<Billy Janitsch>// - **[067cc24f5](facebook/react@067cc24f5)**: Profiler actualDuration bugfix (facebook#13313) //<Brian Vaughn>// - **[3cfab14b9](facebook/react@3cfab14b9)**: Treat focusable as enumerated boolean SVG attribute (facebook#13339) //<Dan Abramov>// - **[3b3b7fcbb](facebook/react@3b3b7fcbb)**: Don't search beyond Sync roots for highest priority work (facebook#13335) //<Dan Abramov>// - **[08e32263f](facebook/react@08e32263f)**: Fix Prettier "No parser" warning while building (facebook#13323) //<Bartosz Kaszubowski>// - **[ac7238856](facebook/react@ac7238856)**: Add support for auxclick event (facebook#11571) //<Jason Quense>// - **[75491a8f4](facebook/react@75491a8f4)**: Add a regression test for facebook#12200 (facebook#12242) //<Gareth Small>// - **[2d0356a52](facebook/react@2d0356a52)**: Make sure that `select` has `multiple` attribute set to appropriate state before appending options (facebook#13270) //<Dmytro Zasyadko>// - **[b179bae0a](facebook/react@b179bae0a)**: Enhance get derived state from props state warning - facebook#12670 (facebook#13317) //<Felix Wu>// - **[15a8f0318](facebook/react@15a8f0318)**: Fix ambiguity in doc comment for isValidElement (facebook#12826) //<Alexey>// - **[5cff21207](facebook/react@5cff21207)**: add flowtype to function signature (facebook#13285) //<ryota-murakami>// - **[b565f4953](facebook/react@b565f4953)**: Minimally support iframes (nested browsing contexts) in selection event handling (facebook#12037) //<Andrew Patton>// - **[1609cf343](facebook/react@1609cf343)**: Warn about rendering Generators (facebook#13312) //<Dan Abramov>// - **[46d5afc54](facebook/react@46d5afc54)**: Replace console.error() with a throw in setTimeout() as last resort exception logging (facebook#13310) //<Dan Abramov>// - **[b3b80a483](facebook/react@b3b80a483)**: Inject react-art renderer into react-devtools (facebook#13173) //<Yunchan Cho>// - **[5e8beec84](facebook/react@5e8beec84)**: Add a regression test for facebook#11602 //<Dan Abramov>// - **[470377bbd](facebook/react@470377bbd)**: Remove extraneous condition //<Dan Abramov>// - **[6db080154](facebook/react@6db080154)**: Remove irrelevant suggestion of a legacy method from a warning (facebook#13169) //<Ideveloper>// - **[f60a7f722](facebook/react@f60a7f722)**: Fix SSR crash on a hasOwnProperty attribute (facebook#13303) //<Dan Abramov>// - **[ff41519ec](facebook/react@ff41519ec)**: Sanitize unknown attribute names for SSR (facebook#13302) //<Dan Abramov>// - **[c44c2a216](facebook/react@c44c2a216)**: More helpful message when passing an element to createElement() (facebook#13131) //<Dylan Cutler>// - **[28cd494bd](facebook/react@28cd494bd)**: Refactor validateDOMNesting a bit (facebook#13300) //<Dan Abramov>// - **[b381f4141](facebook/react@b381f4141)**: Allow Electrons <webview> tag (facebook#13301) //<Philipp Spieß>// - **[0182a7463](facebook/react@0182a7463)**: Fix a crash when using dynamic children in <option> tag (facebook#13261) //<Konstantin Yakushin>// - **[2a2ef7e0f](facebook/react@2a2ef7e0f)**: Remove unnecessary branching from updateContextProvider (facebook#13282) //<Andrew Clark>// - **[840cb1a26](facebook/react@840cb1a26)**: Add an invariant to createRoot() to validate containers (facebook#13279) //<Dan Abramov>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions bc1ea9c...ade5e69 Reviewed By: bvaughn Differential Revision: D9561644 fbshipit-source-id: 3be120d7450f310af458897d54993a6c086cff2f

anp added 2 commits April 4, 2017 14:11

Add Create React Native App to Getting Started.

0edc6e0

Add "ejected only" banner to native code guides.

ac7858f

facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Apr 4, 2017

anp commented Apr 4, 2017

View reviewed changes

skevy requested a review from hramos April 4, 2017 22:50

hramos self-assigned this Apr 5, 2017

hramos added the Documentation label Apr 5, 2017

anp added 6 commits April 6, 2017 12:19

Remove CRNA from More Resources.

73d3f80

Add "Native Builds Only" banner to Geolocation API configuration.

8fbd3fe

Add "Native Builds Only" banner to PushNotificationIOS page.

892e171

Add native build banner to PermissionsAndroid API page.

c1cbecd

Add native build banner to Linking API.

9e733e2

This is partially supported in CRNA right now, but it will be a month or two before we can figure out full support for all of the methods.

anp added 2 commits April 6, 2017 16:54

Add native builds banner to AppRegistry.

d5f7416

It's not *technically* accurate to say it only works in native built apps, since the CRNA entry point does in fact call this indirectly, but CRNA does handle it for you.

hramos approved these changes Apr 24, 2017

View reviewed changes

anp added 2 commits April 24, 2017 10:47

Update getting started language for clarity & parity.

c124004

Address nit re: Expo use instructions.

ffd4444

anp mentioned this pull request Apr 24, 2017

New heading clarifies the usage of AppRegistry #13601

Closed

anp and others added 8 commits April 25, 2017 15:15

Tell users to skip r-n init if they ejected.

054ad90

Rename "Native Builds" section.

54b0e88

Update EjectBanner.js

31c7ebc

Update Debugging.md

1d9b520

Update Geolocation.js

563c0c5

Update Linking.js

6ffeafa

Update PushNotificationIOS.js

dd51bf9

"Projects with Native Code" everywhere.

0837787

facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Apr 25, 2017

facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Apr 26, 2017

facebook-github-bot closed this in 0c9b41f Apr 26, 2017

anp deleted the crna-in-docs branch April 26, 2017 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include Create React Native App in Getting Started #13303

Include Create React Native App in Getting Started #13303

anp commented Apr 4, 2017 •

edited

Loading

anp Apr 4, 2017

anp Apr 4, 2017

hramos Apr 24, 2017

anp Apr 24, 2017

anp Apr 4, 2017

hramos Apr 24, 2017

anp Apr 24, 2017

anp Apr 4, 2017 •

edited

Loading

hramos Apr 24, 2017

anp Apr 4, 2017

brentvatne commented Apr 5, 2017 •

edited

Loading

anp commented Apr 5, 2017

peterp commented Apr 5, 2017 •

edited

Loading

anp commented Apr 6, 2017 •

edited

Loading

hramos commented Apr 6, 2017

anp commented Apr 7, 2017

peterp commented Apr 7, 2017 •

edited

Loading

hramos left a comment

hramos Apr 24, 2017

hramos Apr 24, 2017

hramos Apr 24, 2017

hramos Apr 24, 2017

hramos Apr 24, 2017

hramos Apr 24, 2017

anp Apr 24, 2017

hramos Apr 25, 2017

anp Apr 25, 2017

hramos Apr 24, 2017

anp Apr 24, 2017

anp Apr 25, 2017

hramos Apr 24, 2017

anp commented Apr 24, 2017

facebook-github-bot commented Apr 25, 2017

facebook-github-bot commented Apr 26, 2017


		[Create React Native App](https://github.com/react-community/create-react-native-app) is the easiest way to start building a new React Native application. It allows you to start a project without installing or configuring any native build tools.

		Assuming that you have Node installed, no Xcode or Android Studio installation is required:


		Once you've created your project and opened it in the Expo client app, you can proceed to the [Tutorial](docs/tutorial.html).

		### Caveats


		### Caveats

		Because you don't build any native code with Create React Native App, it's not possible to include custom native modules beyond the React Native APIs and components that are available in the Expo client app.


		If you're integrating React Native into an existing project, you'll want to skip Create React Native App and go directly to setting up the native build environment. See below for instructions on configuring a native build environment for React Native.

		<hr style="margin-top:25px"/>


		This will start a development server for you, and print a QR code in your terminal.

		Install the [Expo](https://expo.io) client app on your iOS or Android phone, make sure your phone is on the same network as your computer, and scan the QR code in your terminal to open your project. The QR scanner is available under the "Projects" tab of the app. Create React Native App also has a [user guide](https://github.com/react-community/create-react-native-app/blob/master/react-native-scripts/template/README.md) you can reference if you have questions specific to the tool.


		## Native Builds

		Follow these instructions if you need your own native build configuration. For example, if you "ejected" from Create React Native app, or if you are integrating React Native into an existing application, you'll need this section.

Include Create React Native App in Getting Started #13303

Include Create React Native App in Getting Started #13303

Conversation

anp commented Apr 4, 2017 • edited Loading

Motivation

Test Plan

TODO before merging

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anp Apr 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brentvatne commented Apr 5, 2017 • edited Loading

anp commented Apr 5, 2017

peterp commented Apr 5, 2017 • edited Loading

anp commented Apr 6, 2017 • edited Loading

hramos commented Apr 6, 2017

anp commented Apr 7, 2017

peterp commented Apr 7, 2017 • edited Loading

hramos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anp commented Apr 24, 2017

facebook-github-bot commented Apr 25, 2017

facebook-github-bot commented Apr 26, 2017

anp commented Apr 4, 2017 •

edited

Loading

anp Apr 4, 2017 •

edited

Loading

brentvatne commented Apr 5, 2017 •

edited

Loading

peterp commented Apr 5, 2017 •

edited

Loading

anp commented Apr 6, 2017 •

edited

Loading

peterp commented Apr 7, 2017 •

edited

Loading