Helping with helloworld on local machine

[cedarmora]

It is not just copy and paste into index.ios.js or index.android.js to make the hello world app work on your local machine, as the text suggests. It requires the app's name to match the component which is registered with the registry. I did the Getting Started page before this and thus had the AwesomeProject app started and could paste into it, but naturally it did not work. To get it working, I originally just basically did find and replace HelloWorldApp -> AwesomeProject, which worked, but the better solution I found was in the stackoverflow topic I linked. If there is a better way to make it easier for beginners to test the hello world app in their local machine, I would be open to it.

Thanks for submitting a PR! Please read these instructions carefully:

• Explain the motivation for making this change.
• Provide a test plan demonstrating that the code is solid.
• Match the code formatting of the rest of the codebase.
• Target the master branch, NOT a "stable" branch.

Motivation (required)

What existing problem does the pull request solve?

Test Plan (required)

A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See What is a Test Plan? to learn more.

If you have added code that should be tested, add tests.

Next Steps

Sign the CLA, if you haven't already.

Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

Make sure all tests pass on both Travis and Circle CI. PRs that break tests are unlikely to be merged.

For more info, see the "Pull Requests" section of our "Contributing" guidelines.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[hramos]

The original intention here is not for people to copy/paste this into the AwesomeApp from the Getting Started. I'm sorry that was not clear.

We can improve the docs here. I'd rather not link to an external site with a solution. Why not either update the tutorial so it is clear that this requires creating a brand new app, or update the code samples in the tutorial so that it indeed allows for direct copy paste?

[cedarmora]

Good point, external links are fragile. I committed some improvements to the instructions to my patch-1 branch, however, I'm not sure how to send that to you or what I should do next (I'm a bit new to git/github).

[hramos]

Sorry for not following up earlier. So this doc has changed quite a bit since then, and I believe the issue has been addressed.

[cedarmora]

Oh good! I figured it wasn't too big of a deal, so I didn't worry about it. Thanks for letting me know!

…

On Fri, Aug 4, 2017 at 2:42 PM Héctor Ramos ***@***.***> wrote: Sorry for not following up earlier. So this doc has changed quite a bit since then, and I believe the issue has been addressed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13138 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH1Ma8R50MmGOWIX-66iDp5OWEq9ptt8ks5sU5BIgaJpZM4Mos-b> .