BREAKING - Remove React addons from react-native-implementation #13095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
janicduplessis
changed the title
|
@ericvicenti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
It's also nice that there's been a warning for many months now, think this shouldn't be too surprising to anyone. |
grabbou
pushed a commit
that referenced
this pull request
Apr 3, 2017
Summary: These modules don't exist in React anymore so this causes new apps to redscreen because the packager cannot resolve those modules. **Test plan** Tested that this and removing NavigationExperimental (it also uses removed React exports) causes UIExplorer to work again. Closes #13095 Differential Revision: D4757762 Pulled By: ericvicenti fbshipit-source-id: bb246d4c6b15f5d3c71e31f133a468aea220f308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modules don't exist in React anymore so this causes new apps to redscreen because the packager cannot resolve those modules.
Test plan
Tested that this and removing NavigationExperimental (it also uses removed React exports) causes UIExplorer to work again.