Fix tvOS issues in React.xcodeproj #12873
Conversation
facebook-github-bot
added
CLA Signed
|
@facebook-github-bot shipit |
|
@janicduplessis has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@facebook-github-bot shipit |
|
@janicduplessis has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@janicduplessis something weird is still going on... the "Import Started" label is not appearing as expected |
|
@dlowder-salesforce Looks like when using the shipit bot it doesn't add the labels, but it does when using the fb internal tool. See your initial PR doesn't have the labels but did import properly. #12869 |
|
Ah ok, thanks for the clarification |
|
Sorry about the bot flakiness guys. I have to learn about how the bot works now it's been rewritten to use webhooks a few months ago by a different team. If it doesn't work just message me or the oncall on Slack. Fb employees use a Chrome extension now (also built by that team) that adds buttons to Chrome to do the import and luckily that one works.
|
facebook-github-bot
added
GH Review: accepted
Import Started
|
@mkonicek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
and removed
Import Started
facebook-github-bot
added
the
Import Started
|
@mkonicek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Trying again, failed with a weird error. |
douglowder
changed the title
|
@dlowder-salesforce I think everything was fixed in a recent commit. |
|
The issues addressed by this PR have already been fixed in dcf3cbe , so closing this. |
Motivation: (1) My previous commit crossed with @mkonicek 's build fix (a8bd462), so it isn't needed any more -- backing it out. (2) RCTJSCErrorHandling needs to be added to React-tvOS target.
CC: @janicduplessis @lacker @ericvicenti