Fix jsdocs for multi-line ES6-style methods #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The function definition and body can be in different places for multi-line declarations, so the docblock might not get pulled in. None of the existing docs seem to be affected, but putting up the fix for posterity. Test Plan: I modified `AlertIOS.alert` (in Libraries/Utilties/AlertIOS.js) to actually have a docblock, and ran `website/publish.sh` (with the push bit commented out). The added doc doesn't get picked up with the current code, but it does with the fix.
facebook-github-bot
added
the
CLA Signed
|
I'll wait for the tests to pass |
vjeux
added a commit
that referenced
this pull request
May 14, 2015
Fix jsdocs for multi-line ES6-style methods
This was referenced Mar 16, 2020
ryanlntn
pushed a commit
to ryanlntn/react-native
that referenced
this pull request
Aug 9, 2022
This bug was due to some code in multiline TextInput which disabled all text checking types by default. We now match the system default instead. Co-authored-by: Liron Yahdav <lyahdav@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The function definition and body can be in different places for multi-line declarations, so the docblock might not get pulled in. None of the existing docs seem to be affected, but putting up the fix for posterity.
Test Plan:
I modified
AlertIOS.alert(in Libraries/Utilties/AlertIOS.js) to actually have a docblock, and ranwebsite/publish.sh(with the push bit commented out). The added doc doesn't get picked up with the current code, but it does with the fix.PS @vjeux: seems like 14c5a23 never got merged in?