Move requireNativeComponent call below the complete MapView definition #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requireNativeComponent should be called after the wrapper component is fully defined, including its static properties.
facebook-github-bot
added
the
CLA Signed
sahrens
added a commit
that referenced
this pull request
May 14, 2015
Move requireNativeComponent call below the complete MapView definition
|
Thanks! You can merge documentation changes yourself, no? Feel free to do-so with obvious fixes like this. |
This was referenced Mar 16, 2020
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Aug 5, 2022
ryanlntn
pushed a commit
to ryanlntn/react-native
that referenced
this pull request
Aug 9, 2022
This adds the appropriate override for AppKit (`setAccessibilityElement:`) so that the `NSTextField` will not get set to be accessible, since its cell instead is already accessible and performs the correct VoiceOver behaviors. VoiceOver now reads as you type in a single-line `TextInput` Co-authored-by: Scott Kyle <skyle@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requireNativeComponent should be called after the wrapper component is fully defined, including its static properties.