Update AdSupportIOS.js #12657
Update AdSupportIOS.js #12657
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Libraries/AdSupport/AdSupportIOS.js
Outdated
| * | ||
| * Before using this you must link the `RCTAdSupport` library. In | ||
| * Xcode, you can manually add the RCTAdSupport.m and RCTAdSupport.h files from | ||
| * node_modules/react-native/Libraries/AdSupport/ to the Libraries/React/Base/ folder of |
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
Libraries/AdSupport/AdSupportIOS.js
Outdated
| * because it triggers an automatic detection from Apple on submission to the App Store | ||
| * to justify its use. | ||
| * | ||
| * Before using this you must link the `RCTAdSupport` library. In |
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
Libraries/AdSupport/AdSupportIOS.js
Outdated
| /** | ||
| * `AdSupport` provides access to the advertisingidentifier. It's not currently linked | ||
| * because it triggers an automatic detection from Apple on submission to the App Store | ||
| * to justify its use. |
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
Libraries/AdSupport/AdSupportIOS.js
Outdated
| @@ -11,6 +11,20 @@ | |||
| */ | |||
| 'use strict'; | |||
|
|
|||
| /** | |||
| * `AdSupport` provides access to the advertisingidentifier. It's not currently linked | |||
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
Libraries/AdSupport/AdSupportIOS.js
Outdated
| @@ -11,6 +11,20 @@ | |||
| */ | |||
| 'use strict'; | |||
|
|
|||
| /** | |||
| * `AdSupport` provides access to the advertisingidentifier. It's not currently linked | |||
| * because it triggers an automatic detection from Apple on submission to the App Store | |||
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
Libraries/AdSupport/AdSupportIOS.js
Outdated
| * `AdSupport` provides access to the advertisingidentifier. It's not currently linked | ||
| * because it triggers an automatic detection from Apple on submission to the App Store | ||
| * to justify its use. | ||
| * |
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
Remove trailing spaecs
|
Do you have a test plan? Specifically I'd like to know if you built the website and verified this renders properly. |
|
needs-revision because of missing test plan. In this case a screenshot would be fine. Try:
|
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Test plan |
facebook-github-bot
added
GH Review: accepted
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
| * You can refer to [Linking](docs/linking-libraries-ios.html) for help. | ||
| * | ||
| */ | ||
|
|
||
| module.exports = { | ||
| getAdvertisingId: function(onSuccess: Function, onFailure: Function) { |
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
Libraries/AdSupport/AdSupportIOS.js
Outdated
| * of your current project. | ||
| * | ||
| * You can refer to [Linking](docs/linking-libraries-ios.html) for help. | ||
| * |
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
Libraries/AdSupport/AdSupportIOS.js
Outdated
| * You can refer to [Linking](docs/linking-libraries-ios.html) for help. | ||
| * | ||
| */ | ||
|
|
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
facebook-github-bot
removed
the
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
the
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Looks like RN unlinked the RCTAdSupport module from the React project because it triggers some automatic detection from Apple. (from this thread facebook#1303). So this includes the instructions to manually add RCTAdSupport files from node_modules. See: facebook#12623 Closes facebook#12657 Differential Revision: D4962321 Pulled By: hramos fbshipit-source-id: ed9aed3b4c16e72d1f9557f5c16fcdadfdd743ea
Looks like RN unlinked the RCTAdSupport module from the React project because it triggers some automatic detection from Apple. (from this thread #1303). So this includes the instructions to manually add RCTAdSupport files from node_modules.
See: #12623