Refreshed design. #12575
Refreshed design. #12575
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
facebook-github-bot
added
GH Review: accepted
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
added
Import Failed
and removed
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
the
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
removed
the
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
Summary: This is facebook#12292, but squashed into a single commit. This should help land the PR cleanly, as the commit history for facebook#12292 was in a bad state: see how 1cbf79d expects `"mkdirp": "^0.5.1"` in `package.json`, but the earlier 66920e4 had changed this to `"mkdirp": "*",`. Verified the website built and run. Confirmed docs, apis, components were generated. Confirmed landing page, showcase, blog, docs, help page all load and look as expected. Closes facebook#12575 Differential Revision: D4617979 Pulled By: hramos fbshipit-source-id: 86e2d0b36ccd25fc7f2e9f3b1351f97e7ba64d57
Summary: This is facebook#12292, but squashed into a single commit. This should help land the PR cleanly, as the commit history for facebook#12292 was in a bad state: see how 1cbf79d expects `"mkdirp": "^0.5.1"` in `package.json`, but the earlier 66920e4 had changed this to `"mkdirp": "*",`. Verified the website built and run. Confirmed docs, apis, components were generated. Confirmed landing page, showcase, blog, docs, help page all load and look as expected. Closes facebook#12575 Differential Revision: D4617979 Pulled By: hramos fbshipit-source-id: 86e2d0b36ccd25fc7f2e9f3b1351f97e7ba64d57
Summary: This is #12292, but squashed into a single commit. This should help land the PR cleanly, as the commit history for #12292 was in a bad state: see how 1cbf79d expects `"mkdirp": "^0.5.1"` in `package.json`, but the earlier 66920e4 had changed this to `"mkdirp": "*",`. Verified the website built and run. Confirmed docs, apis, components were generated. Confirmed landing page, showcase, blog, docs, help page all load and look as expected. Closes #12575 Differential Revision: D4617979 Pulled By: hramos fbshipit-source-id: 86e2d0b36ccd25fc7f2e9f3b1351f97e7ba64d57
This is #12292, but squashed into a single commit. This should help land the PR cleanly, as the commit history for #12292 was in a bad state: see how 1cbf79d expects
"mkdirp": "^0.5.1"inpackage.json, but the earlier 66920e4 had changed this to"mkdirp": "*",.Test plan
Verified the website built and run.
Confirmed docs, apis, components were generated.
Confirmed landing page, showcase, blog, docs, help page all load and look as expected.