Native Animated - Fix timing animation delay on iOS #12443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
cc @ide |
|
@facebook-github-bot shipit |
|
@ide has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ide Could you try this again? |
|
@facebook-github-bot shipit |
|
@ide has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this pull request
May 7, 2017
Summary: Delay was broken with native animations on iOS. After checking what android does to handle delay, I noticed it does nothing at all since the delay is already handled when generating the animation frames. This removes all code that tried to handle delay on iOS since it is not needed and breaks it. Also updated an example to have delay in UI explorer. Fixes facebook#12388 **Test plan** Tested that delay works in UIExplorer on iOS and Android. Closes facebook#12443 Differential Revision: D4582514 Pulled By: javache fbshipit-source-id: dc53295e716c8476c71ccd578380962f056de2be
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
May 25, 2017
Summary: Delay was broken with native animations on iOS. After checking what android does to handle delay, I noticed it does nothing at all since the delay is already handled when generating the animation frames. This removes all code that tried to handle delay on iOS since it is not needed and breaks it. Also updated an example to have delay in UI explorer. Fixes #12388 **Test plan** Tested that delay works in UIExplorer on iOS and Android. Closes facebook/react-native#12443 Differential Revision: D4582514 Pulled By: javache fbshipit-source-id: dc53295e716c8476c71ccd578380962f056de2be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay was broken with native animations on iOS. After checking what android does to handle delay, I noticed it does nothing at all since the delay is already handled when generating the animation frames. This removes all code that tried to handle delay on iOS since it is not needed and breaks it. Also updated an example to have delay in UI explorer.
Fixes #12388
Test plan
Tested that delay works in UIExplorer on iOS and Android.