Discover symlinked scoped dependencies in findSymlinksPaths #12158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon the work by @harshil07 (thank you!) in pull request #11810, adding support for symlinked scoped dependencies (like
@foo/bar
). Now, when we see an @-prefixed folder, we'll look inside it for symlinks.If a project isn't using scoped dependencies, this change doesn't cause any additional file system operations.
Test plan
@foo/bar
in your project'snode_modules
folder (e.g., by usingnpm link
oryarn link
).@foo
will be a real folder, butbar
will be a symlink.react-native bundle
,react-native run-ios
, or another command that will explore your dependency graph.Code formatting
Please let me know if there's anything you'd like me to address!