Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover symlinked scoped dependencies in findSymlinksPaths #12158

Closed

Conversation

alexhanson
Copy link

@alexhanson alexhanson commented Feb 1, 2017

This builds upon the work by @harshil07 (thank you!) in pull request #11810, adding support for symlinked scoped dependencies (like @foo/bar). Now, when we see an @-prefixed folder, we'll look inside it for symlinks.

If a project isn't using scoped dependencies, this change doesn't cause any additional file system operations.

Test plan

  1. Create a symlink like @foo/bar in your project's node_modules folder (e.g., by using npm link or yarn link). @foo will be a real folder, but bar will be a symlink.
  2. Run react-native bundle, react-native run-ios, or another command that will explore your dependency graph.

Code formatting
Please let me know if there's anything you'd like me to address!

…` by looking inside @-prefixed folders for symlinks.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 23, 2017
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@alexhanson
Copy link
Author

Closing this pull request given that #12435 was accepted in commit c97c1e5.

@alexhanson alexhanson closed this Mar 23, 2017
@alexhanson
Copy link
Author

Contrary to my comment above, #12435 addressed a different issue than this pull request. However, #12400 does address the issue I described here, and it remains open. Anybody having issues with symlinked scoped dependencies should look at #12400 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants