Fixes #5688 onChangeVisibleRows for Android #11945
Conversation
|
By analyzing the blame information on this pull request, we identified @AaaChiuuu and @foghina to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
ptomasroos
changed the title
|
@hramos Can we get someone to look at this ? |
Since the ScrollEvent pool throttles updates before could be missed in the case of very fast scrolling. These scheduled update frames are now being merged in the case an event is within the pool.
|
Does anyone know when this might be released please? |
|
Why this PR is close? |
|
No need for it now when flatlist is available.
|
|
flatlist? |
|
@ptomasroos Can we use flat list in rn-0.42.0 or do we have to checkout master? |
|
Would still be nice when that error would be fixed anyway. |
|
@ptomasroos why can't this be merged? FlatList is still experimental and people still use the normal listview... |
|
No one took a look on it for quite some time. Feel free to copy the branch and open a PR if you need it! We've migrated to FlatList |
|
@ptomasroos How can I use FlatList right now? Do you use the master branch? |
This PR includes a fix for the old missing feature of onChangeVisibleRows on Android.
Fixes #5688
Also reported on product pains https://productpains.com/post/react-native/listview-onchangevisiblerows-android-support
Test plan (required)
Test through UIExplorer which has a callback on the ListView Paging example and walking through rows + sections and making sure visible rows matches to whats visible.